Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(758)

Issue 2310423002: [MD History] Move background-clip div behind items. (Closed)

Created:
4 years, 3 months ago by calamity
Modified:
4 years, 3 months ago
Reviewers:
tsergeant
CC:
chromium-reviews, Patrick Dubroy, michaelpg+watch-md-ui_chromium.org, dbeam+watch-history_chromium.org, pam+watch_chromium.org, arv+watch_chromium.org, chrome-apps-syd-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[MD History] Move background-clip div behind items. This CL fixes an issue where links in history couldn't be clicked because the invisible background clip was covering it. BUG=641223 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/6388b195d078e2068cb86191f589693cf7a51bae Cr-Commit-Position: refs/heads/master@{#416868}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M chrome/browser/resources/md_history/app.vulcanized.html View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/resources/md_history/history_item.html View 2 chunks +1 line, -1 line 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 9 (4 generated)
calamity
4 years, 3 months ago (2016-09-07 05:45:01 UTC) #3
tsergeant
lgtm lgtm, let's see if we can avoid breaking canary
4 years, 3 months ago (2016-09-07 05:53:31 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2310423002/1
4 years, 3 months ago (2016-09-07 05:53:49 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-07 06:55:59 UTC) #7
commit-bot: I haz the power
4 years, 3 months ago (2016-09-07 06:57:44 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6388b195d078e2068cb86191f589693cf7a51bae
Cr-Commit-Position: refs/heads/master@{#416868}

Powered by Google App Engine
This is Rietveld 408576698