Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(202)

Issue 2277303003: In update-w3c-test-expectations, handle failure to fetch results. (Closed)

Created:
4 years, 3 months ago by qyearsley
Modified:
4 years, 3 months ago
Reviewers:
Dirk Pranke
CC:
blink-reviews, blink-reviews-w3ctests_chromium.org, cbentzel+watch_chromium.org, chromium-reviews, Dirk Pranke, jsbell
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

In update-w3c-test-expectations, handle failure to fetch results. Specifically, when no layout tests are fetched for a particular build, log a warning and continue instead of raising an exception and aborting. I noticed this error when running the script on my workstation. This CL also adds several TODO notes. BUG=629275 Committed: https://crrev.com/0f77323cdf30b116f8055b11ef890d6a835b2044 Cr-Commit-Position: refs/heads/master@{#414497}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+84 lines, -4 lines) Patch
M third_party/WebKit/Tools/Scripts/webkitpy/common/net/buildbot_mock.py View 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/common/net/layouttestresults.py View 1 chunk +7 lines, -0 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/w3c/update_w3c_test_expectations.py View 3 chunks +17 lines, -3 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/w3c/update_w3c_test_expectations_unittest.py View 2 chunks +57 lines, -1 line 1 comment Download

Messages

Total messages: 9 (3 generated)
qyearsley
4 years, 3 months ago (2016-08-25 16:00:42 UTC) #2
qyearsley
https://codereview.chromium.org/2277303003/diff/1/third_party/WebKit/Tools/Scripts/webkitpy/w3c/update_w3c_test_expectations_unittest.py File third_party/WebKit/Tools/Scripts/webkitpy/w3c/update_w3c_test_expectations_unittest.py (right): https://codereview.chromium.org/2277303003/diff/1/third_party/WebKit/Tools/Scripts/webkitpy/w3c/update_w3c_test_expectations_unittest.py#newcode16 third_party/WebKit/Tools/Scripts/webkitpy/w3c/update_w3c_test_expectations_unittest.py:16: class UpdateW3CTestExpectationsTest(unittest.TestCase, W3CExpectationsLineAdder): Another TODO which I plan to ...
4 years, 3 months ago (2016-08-25 16:02:47 UTC) #3
Dirk Pranke
lgtm
4 years, 3 months ago (2016-08-25 17:20:15 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2277303003/1
4 years, 3 months ago (2016-08-25 17:23:43 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-08-25 18:59:22 UTC) #7
commit-bot: I haz the power
4 years, 3 months ago (2016-08-25 19:03:03 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0f77323cdf30b116f8055b11ef890d6a835b2044
Cr-Commit-Position: refs/heads/master@{#414497}

Powered by Google App Engine
This is Rietveld 408576698