third_party/WebKit/Tools/Scripts/webkitpy/common/net/buildbot_mock.py - Issue 2277303003: In update-w3c-test-expectations, handle failure to fetch results.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Tools/Scripts/webkitpy/common/net/buildbot_mock.py

Issue 2277303003: In update-w3c-test-expectations, handle failure to fetch results. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | third_party/WebKit/Tools/Scripts/webkitpy/common/net/layouttestresults.py » ('j') | third_party/WebKit/Tools/Scripts/webkitpy/w3c/update_w3c_test_expectations_unittest.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Tools/Scripts/webkitpy/common/net/buildbot_mock.py

diff --git a/third_party/WebKit/Tools/Scripts/webkitpy/common/net/buildbot_mock.py b/third_party/WebKit/Tools/Scripts/webkitpy/common/net/buildbot_mock.py

index bd4bdd8b9ebdd30d9936117331c11e89a635be8c..2ffdcfc8d029709f58d4ba8dce0e2a9ee75461c6 100644

--- a/third_party/WebKit/Tools/Scripts/webkitpy/common/net/buildbot_mock.py

+++ b/third_party/WebKit/Tools/Scripts/webkitpy/common/net/buildbot_mock.py

@@ -31,6 +31,9 @@ from webkitpy.common.net.layouttestresults import LayoutTestResults

from webkitpy.common.net.layouttestresults_unittest import LayoutTestResultsTest

+# TODO(qyearsley): Instead of canned results from another module, other unit

+# tests may be a little easier to understand if this returned None by default

+# when there are no canned results to return.

class MockBuildBot(BuildBot):

def __init__(self):