third_party/WebKit/Tools/Scripts/webkitpy/common/net/layouttestresults.py - Issue 2277303003: In update-w3c-test-expectations, handle failure to fetch results.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Tools/Scripts/webkitpy/common/net/layouttestresults.py

Issue 2277303003: In update-w3c-test-expectations, handle failure to fetch results. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Tools/Scripts/webkitpy/common/net/buildbot_mock.py ('k') | third_party/WebKit/Tools/Scripts/webkitpy/w3c/update_w3c_test_expectations.py » ('j') | third_party/WebKit/Tools/Scripts/webkitpy/w3c/update_w3c_test_expectations_unittest.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Tools/Scripts/webkitpy/common/net/layouttestresults.py

diff --git a/third_party/WebKit/Tools/Scripts/webkitpy/common/net/layouttestresults.py b/third_party/WebKit/Tools/Scripts/webkitpy/common/net/layouttestresults.py

index 4c6e324759b1b449f4751d49ce0c42e613bcc07a..50a3dd9c9eb1432365c27c1fd0d1e58bcdd049e3 100644

--- a/third_party/WebKit/Tools/Scripts/webkitpy/common/net/layouttestresults.py

+++ b/third_party/WebKit/Tools/Scripts/webkitpy/common/net/layouttestresults.py

@@ -51,9 +51,16 @@ class LayoutTestResult(object):

return 'PASS' in self.actual_results()

def did_run_as_expected(self):

+ # TODO(qyearsley): For correctness, this should be:

+ # return not self._result_dict.get('is_unexpected', False)

+ # (Right now for expected results it's not added to the result dict

+ # but in theory it could be present.)

return 'is_unexpected' not in self._result_dict

def is_missing_image(self):

+ # TODO(qyearsley): Change this to:

+ # self._result_dict.get('is_missing_image', False)

+ # The following method should likewise be changed.

return 'is_missing_image' in self._result_dict

def is_missing_text(self):