Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(351)

Issue 2274413003: Remove NeedToDispatchSelectEvent argument of HTMLTextFormControlElement::select(). (Closed)

Created:
4 years, 4 months ago by tkent
Modified:
4 years, 4 months ago
Reviewers:
yosin_UTC9
CC:
blink-reviews, blink-reviews-html_chromium.org, chromium-reviews, dglazkov+blink
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove NeedToDispatchSelectEvent argument of HTMLTextFormControlElement::select(). A callsite with NotDispatchSelectEvent is updated so that it calls the four-argument version of setSelectedRange(). This CL has no behavior changes. BUG=640861 Committed: https://crrev.com/f04e619a56c036526512eec982029e8e0cf095e1 Cr-Commit-Position: refs/heads/master@{#414349}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M third_party/WebKit/Source/core/html/HTMLInputElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/HTMLTextFormControlElement.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/HTMLTextFormControlElement.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/html/forms/TextFieldInputType.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 15 (9 generated)
tkent
yosin@, would you review this please?
4 years, 4 months ago (2016-08-25 04:42:52 UTC) #6
yosin_UTC9
lgtm
4 years, 4 months ago (2016-08-25 04:50:51 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2274413003/1
4 years, 4 months ago (2016-08-25 04:51:23 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2274413003/1
4 years, 4 months ago (2016-08-25 06:20:17 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-25 07:29:59 UTC) #13
commit-bot: I haz the power
4 years, 4 months ago (2016-08-25 07:31:30 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f04e619a56c036526512eec982029e8e0cf095e1
Cr-Commit-Position: refs/heads/master@{#414349}

Powered by Google App Engine
This is Rietveld 408576698