third_party/WebKit/Source/core/html/forms/TextFieldInputType.cpp - Issue 2274413003: Remove NeedToDispatchSelectEvent argument of HTMLTextFormControlElement::select().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/forms/TextFieldInputType.cpp

Issue 2274413003: Remove NeedToDispatchSelectEvent argument of HTMLTextFormControlElement::select(). (Closed)

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/html/forms/TextFieldInputType.cpp

diff --git a/third_party/WebKit/Source/core/html/forms/TextFieldInputType.cpp b/third_party/WebKit/Source/core/html/forms/TextFieldInputType.cpp

index f3c8f55b5a766928778e7fe5222a7b51fc07b79f..b2257e00d366bb3c87f25dd87c2f83a801908d55 100644

--- a/third_party/WebKit/Source/core/html/forms/TextFieldInputType.cpp

+++ b/third_party/WebKit/Source/core/html/forms/TextFieldInputType.cpp

@@ -538,7 +538,7 @@ void TextFieldInputType::updateView()

void TextFieldInputType::focusAndSelectSpinButtonOwner()

{

element().focus();

- element().select(NotDispatchSelectEvent);

+ element().setSelectionRange(0, std::numeric_limits<int>::max(), SelectionHasNoDirection, NotDispatchSelectEvent);

}

bool TextFieldInputType::shouldSpinButtonRespondToMouseEvents()

« no previous file with comments | « third_party/WebKit/Source/core/html/HTMLTextFormControlElement.cpp ('k') | no next file » | no next file with comments »