Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(468)

Unified Diff: third_party/WebKit/Source/core/html/forms/TextFieldInputType.cpp

Issue 2274413003: Remove NeedToDispatchSelectEvent argument of HTMLTextFormControlElement::select(). (Closed)
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/core/html/HTMLTextFormControlElement.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/html/forms/TextFieldInputType.cpp
diff --git a/third_party/WebKit/Source/core/html/forms/TextFieldInputType.cpp b/third_party/WebKit/Source/core/html/forms/TextFieldInputType.cpp
index f3c8f55b5a766928778e7fe5222a7b51fc07b79f..b2257e00d366bb3c87f25dd87c2f83a801908d55 100644
--- a/third_party/WebKit/Source/core/html/forms/TextFieldInputType.cpp
+++ b/third_party/WebKit/Source/core/html/forms/TextFieldInputType.cpp
@@ -538,7 +538,7 @@ void TextFieldInputType::updateView()
void TextFieldInputType::focusAndSelectSpinButtonOwner()
{
element().focus();
- element().select(NotDispatchSelectEvent);
+ element().setSelectionRange(0, std::numeric_limits<int>::max(), SelectionHasNoDirection, NotDispatchSelectEvent);
}
bool TextFieldInputType::shouldSpinButtonRespondToMouseEvents()
« no previous file with comments | « third_party/WebKit/Source/core/html/HTMLTextFormControlElement.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698