Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(65)

Side by Side Diff: third_party/WebKit/Source/core/html/HTMLInputElement.cpp

Issue 2274413003: Remove NeedToDispatchSelectEvent argument of HTMLTextFormControlElement::select(). (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/html/HTMLTextFormControlElement.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2001 Dirk Mueller (mueller@kde.org) 4 * (C) 2001 Dirk Mueller (mueller@kde.org)
5 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All r ights reserved. 5 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All r ights reserved.
6 * (C) 2006 Alexey Proskuryakov (ap@nypop.com) 6 * (C) 2006 Alexey Proskuryakov (ap@nypop.com)
7 * Copyright (C) 2007 Samuel Weinig (sam@webkit.org) 7 * Copyright (C) 2007 Samuel Weinig (sam@webkit.org)
8 * Copyright (C) 2010 Google Inc. All rights reserved. 8 * Copyright (C) 2010 Google Inc. All rights reserved.
9 * Copyright (C) 2008 Torch Mobile Inc. All rights reserved. (http://www.torchmo bile.com/) 9 * Copyright (C) 2008 Torch Mobile Inc. All rights reserved. (http://www.torchmo bile.com/)
10 * Copyright (C) 2012 Samsung Electronics. All rights reserved. 10 * Copyright (C) 2012 Samsung Electronics. All rights reserved.
(...skipping 310 matching lines...) Expand 10 before | Expand all | Expand 10 after
321 bool HTMLInputElement::shouldShowFocusRingOnMouseFocus() const 321 bool HTMLInputElement::shouldShowFocusRingOnMouseFocus() const
322 { 322 {
323 return m_inputType->shouldShowFocusRingOnMouseFocus(); 323 return m_inputType->shouldShowFocusRingOnMouseFocus();
324 } 324 }
325 325
326 void HTMLInputElement::updateFocusAppearance(SelectionBehaviorOnFocus selectionB ehavior) 326 void HTMLInputElement::updateFocusAppearance(SelectionBehaviorOnFocus selectionB ehavior)
327 { 327 {
328 if (isTextField()) { 328 if (isTextField()) {
329 switch (selectionBehavior) { 329 switch (selectionBehavior) {
330 case SelectionBehaviorOnFocus::Reset: 330 case SelectionBehaviorOnFocus::Reset:
331 select(DispatchSelectEvent); 331 select();
332 break; 332 break;
333 case SelectionBehaviorOnFocus::Restore: 333 case SelectionBehaviorOnFocus::Restore:
334 restoreCachedSelection(); 334 restoreCachedSelection();
335 break; 335 break;
336 case SelectionBehaviorOnFocus::None: 336 case SelectionBehaviorOnFocus::None:
337 return; 337 return;
338 } 338 }
339 // TODO(tkent): scrollRectToVisible is a workaround of a bug of 339 // TODO(tkent): scrollRectToVisible is a workaround of a bug of
340 // FrameSelection::revealSelection(). It doesn't scroll correctly in a 340 // FrameSelection::revealSelection(). It doesn't scroll correctly in a
341 // case of RangeSelection. crbug.com/443061. 341 // case of RangeSelection. crbug.com/443061.
(...skipping 1570 matching lines...) Expand 10 before | Expand all | Expand 10 after
1912 { 1912 {
1913 return m_inputTypeView->hasFallbackContent(); 1913 return m_inputTypeView->hasFallbackContent();
1914 } 1914 }
1915 1915
1916 void HTMLInputElement::setFilesFromPaths(const Vector<String>& paths) 1916 void HTMLInputElement::setFilesFromPaths(const Vector<String>& paths)
1917 { 1917 {
1918 return m_inputType->setFilesFromPaths(paths); 1918 return m_inputType->setFilesFromPaths(paths);
1919 } 1919 }
1920 1920
1921 } // namespace blink 1921 } // namespace blink
OLDNEW
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/html/HTMLTextFormControlElement.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698