third_party/WebKit/Source/core/html/HTMLTextFormControlElement.h - Issue 2274413003: Remove NeedToDispatchSelectEvent argument of HTMLTextFormControlElement::select().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/HTMLTextFormControlElement.h

Issue 2274413003: Remove NeedToDispatchSelectEvent argument of HTMLTextFormControlElement::select(). (Closed)

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/html/HTMLTextFormControlElement.h

diff --git a/third_party/WebKit/Source/core/html/HTMLTextFormControlElement.h b/third_party/WebKit/Source/core/html/HTMLTextFormControlElement.h

index b4e03dfba403de8dae408db3ade09efab1ee7c6e..9ebd2854cd85817e042223cce39f9e3d3273c60f 100644

--- a/third_party/WebKit/Source/core/html/HTMLTextFormControlElement.h

+++ b/third_party/WebKit/Source/core/html/HTMLTextFormControlElement.h

@@ -67,7 +67,7 @@ public:

void setSelectionStart(int);

void setSelectionEnd(int);

void setSelectionDirection(const String&);

- void select(NeedToDispatchSelectEvent = DispatchSelectEvent);

+ void select();

virtual void setRangeText(const String& replacement, ExceptionState&);

virtual void setRangeText(const String& replacement, unsigned start, unsigned end, const String& selectionMode, ExceptionState&);

// Web-exposed setSelectionRange() function. This translates "none"