Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issue 2274273002: Remove redundant SkBitmap::drawsNothing() check in AddToHomescreenDataFetcher. (Closed)

Created:
4 years, 3 months ago by pkotwicz
Modified:
4 years, 3 months ago
Reviewers:
dominickn
CC:
chromium-reviews, dominickn+watch_chromium.org, Xi Han
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove redundant SkBitmap::drawsNothing() check in AddToHomescreenDataFetcher. The check is already done in InstallableManager. BUG=None TEST=InstallableManagerBrowserTest.CheckManifestCorruptedIcon Committed: https://crrev.com/12512826329c0c29729620614db51c1859506091 Cr-Commit-Position: refs/heads/master@{#414143}

Patch Set 1 #

Patch Set 2 : Merge branch 'master' into webapk_dialog_detector0 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -2 lines) Patch
M chrome/browser/android/webapps/add_to_homescreen_data_fetcher.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/installable/installable_manager_browsertest.cc View 1 chunk +20 lines, -0 lines 0 comments Download
A chrome/test/data/banners/bad_icon.png View 1 Binary file 0 comments Download
A chrome/test/data/banners/manifest_bad_icon.json View 1 1 chunk +13 lines, -0 lines 0 comments Download
A + chrome/test/data/banners/manifest_bad_icon_test_page.html View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (5 generated)
pkotwicz
Dominick, can you please take a look?
4 years, 3 months ago (2016-08-24 19:24:48 UTC) #2
dominickn
lgtm, thanks!
4 years, 3 months ago (2016-08-24 19:30:32 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2274273002/20001
4 years, 3 months ago (2016-08-24 19:37:34 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-08-24 21:05:01 UTC) #8
commit-bot: I haz the power
4 years, 3 months ago (2016-08-24 21:07:24 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/12512826329c0c29729620614db51c1859506091
Cr-Commit-Position: refs/heads/master@{#414143}

Powered by Google App Engine
This is Rietveld 408576698