chrome/test/data/banners/manifest_bad_icon_test_page.html - Issue 2274273002: Remove redundant SkBitmap::drawsNothing() check in AddToHomescreenDataFetcher.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/test/data/banners/manifest_bad_icon_test_page.html

Issue 2274273002: Remove redundant SkBitmap::drawsNothing() check in AddToHomescreenDataFetcher. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Merge branch 'master' into webapk_dialog_detector0 Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 <html>	1 <html>

2 <head>	2 <head>

3 <title>Web app banner test page</title>	3 <title>Web app banner test page</title>

4 <link rel="manifest" href="manifest_short_name_only.json" />	4 <link rel="manifest" href="manifest_bad_icon.json" />

5 <script src="main.js"></script>	5 <script src="main.js"></script>

6 </head>	6 </head>

7 <body onload="initialize()">	7 <body onload="initialize()">

8 Do-nothing page with a service worker.	8 Do-nothing page with a service worker.

9 </body>	9 </body>

10 </html>	10 </html>

OLD	NEW

« no previous file with comments | « chrome/test/data/banners/manifest_bad_icon.json ('k') | no next file » | no next file with comments »