chrome/browser/android/webapps/add_to_homescreen_data_fetcher.cc - Issue 2274273002: Remove redundant SkBitmap::drawsNothing() check in AddToHomescreenDataFetcher.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/android/webapps/add_to_homescreen_data_fetcher.cc

Issue 2274273002: Remove redundant SkBitmap::drawsNothing() check in AddToHomescreenDataFetcher. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Merge branch 'master' into webapk_dialog_detector0 Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/android/webapps/add_to_homescreen_data_fetcher.cc

diff --git a/chrome/browser/android/webapps/add_to_homescreen_data_fetcher.cc b/chrome/browser/android/webapps/add_to_homescreen_data_fetcher.cc

index b9dbccfb1790ce846f9b687e1ca795b6e9171960..b5a951545af9be41aa2c5886e690c3c99674cf40 100644

--- a/chrome/browser/android/webapps/add_to_homescreen_data_fetcher.cc

+++ b/chrome/browser/android/webapps/add_to_homescreen_data_fetcher.cc

@@ -172,7 +172,7 @@ void AddToHomescreenDataFetcher::OnDidPerformInstallableCheck(

weak_observer_->OnUserTitleAvailable(shortcut_info_.user_title);

- if (data.icon && !data.icon->drawsNothing()) {

+ if (data.icon) {

// TODO(hanxi): implement WebAPK path if shortcut_info_.url has a secure

// scheme and data.is_installable is true.

shortcut_info_.icon_url = data.icon_url;

« no previous file with comments | « no previous file | chrome/browser/installable/installable_manager_browsertest.cc » ('j') | no next file with comments »