chrome/test/data/banners/manifest_bad_icon_test_page.html - Issue 2274273002: Remove redundant SkBitmap::drawsNothing() check in AddToHomescreenDataFetcher.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/data/banners/manifest_bad_icon_test_page.html

Issue 2274273002: Remove redundant SkBitmap::drawsNothing() check in AddToHomescreenDataFetcher. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Merge branch 'master' into webapk_dialog_detector0 Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/test/data/banners/manifest_bad_icon_test_page.html

diff --git a/chrome/test/data/banners/manifest_short_name_only_test_page.html b/chrome/test/data/banners/manifest_bad_icon_test_page.html

similarity index 75%

copy from chrome/test/data/banners/manifest_short_name_only_test_page.html

copy to chrome/test/data/banners/manifest_bad_icon_test_page.html

index 850201e5c6276f29964c2713bc9683bce54aa95d..e19ce18330499f431d966f7a8fb36aab6a5e3cd6 100644

--- a/chrome/test/data/banners/manifest_short_name_only_test_page.html

+++ b/chrome/test/data/banners/manifest_bad_icon_test_page.html

@@ -1,7 +1,7 @@

<html>

<head>

<title>Web app banner test page</title>

- <link rel="manifest" href="manifest_short_name_only.json" />

+ <link rel="manifest" href="manifest_bad_icon.json" />

</head>

« no previous file with comments | « chrome/test/data/banners/manifest_bad_icon.json ('k') | no next file » | no next file with comments »