Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2273633004:
Add Cookie.CookieLineCookieValueValidity histogram (Closed)
DescriptionAdd Cookie.CookieLineCookieValueValidity histogram
net::ParsedCookie::SetValue() applies a strict check to the passed-in value,
but ParsedCookie::ParseTokenValuePairs() applies a weaker check. It
would nice if this was consistent.
Add a histogram to determine the degree of compatibility problems with making
it consistent.
BUG=638117
Committed: https://crrev.com/b08ddda70e3f9c261d1fb87a2e63fbc14f9b8775
Cr-Commit-Position: refs/heads/master@{#414690}
Patch Set 1 #
Total comments: 2
Patch Set 2 : histogram.h -> histogram_macros.h #
Messages
Total messages: 27 (15 generated)
The CQ bit was checked by ricea@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
Description was changed from ========== Add Cookie.CookieValueValidity histogram net::ParsedCookie::SetValue() applies a strict check to the passed-in value, but ParsedCookie::ParseTokenValuePairs() applies a weaker check. It would nice if this was consistent. Add a histogram to determine the degree of compatibility problems with making it consistent. BUG=638117 ========== to ========== Add Cookie.CookieLineCookieValueValidity histogram net::ParsedCookie::SetValue() applies a strict check to the passed-in value, but ParsedCookie::ParseTokenValuePairs() applies a weaker check. It would nice if this was consistent. Add a histogram to determine the degree of compatibility problems with making it consistent. BUG=638117 ==========
ricea@chromium.org changed reviewers: + mmenke@chromium.org
LGTM. Think that comparing with what other browsers do may be a better idea here than histograms, though.
The CQ bit was checked by ricea@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
ricea@chromium.org changed reviewers: + isherman@chromium.org
+asvitkine for histograms.xml
metrics lgtm https://codereview.chromium.org/2273633004/diff/1/net/cookies/parsed_cookie.cc File net/cookies/parsed_cookie.cc (right): https://codereview.chromium.org/2273633004/diff/1/net/cookies/parsed_cookie.c... net/cookies/parsed_cookie.cc:48: #include "base/metrics/histogram.h" nit: histogram_macros
The CQ bit was checked by ricea@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from isherman@chromium.org, mmenke@chromium.org Link to the patchset: https://codereview.chromium.org/2273633004/#ps20001 (title: "histogram.h -> histogram_macros.h")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
https://codereview.chromium.org/2273633004/diff/1/net/cookies/parsed_cookie.cc File net/cookies/parsed_cookie.cc (right): https://codereview.chromium.org/2273633004/diff/1/net/cookies/parsed_cookie.c... net/cookies/parsed_cookie.cc:48: #include "base/metrics/histogram.h" On 2016/08/25 20:04:49, Ilya Sherman wrote: > nit: histogram_macros Fixed, thanks.
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)
The CQ bit was checked by ricea@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Add Cookie.CookieLineCookieValueValidity histogram net::ParsedCookie::SetValue() applies a strict check to the passed-in value, but ParsedCookie::ParseTokenValuePairs() applies a weaker check. It would nice if this was consistent. Add a histogram to determine the degree of compatibility problems with making it consistent. BUG=638117 ========== to ========== Add Cookie.CookieLineCookieValueValidity histogram net::ParsedCookie::SetValue() applies a strict check to the passed-in value, but ParsedCookie::ParseTokenValuePairs() applies a weaker check. It would nice if this was consistent. Add a histogram to determine the degree of compatibility problems with making it consistent. BUG=638117 ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Add Cookie.CookieLineCookieValueValidity histogram net::ParsedCookie::SetValue() applies a strict check to the passed-in value, but ParsedCookie::ParseTokenValuePairs() applies a weaker check. It would nice if this was consistent. Add a histogram to determine the degree of compatibility problems with making it consistent. BUG=638117 ========== to ========== Add Cookie.CookieLineCookieValueValidity histogram net::ParsedCookie::SetValue() applies a strict check to the passed-in value, but ParsedCookie::ParseTokenValuePairs() applies a weaker check. It would nice if this was consistent. Add a histogram to determine the degree of compatibility problems with making it consistent. BUG=638117 Committed: https://crrev.com/b08ddda70e3f9c261d1fb87a2e63fbc14f9b8775 Cr-Commit-Position: refs/heads/master@{#414690} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/b08ddda70e3f9c261d1fb87a2e63fbc14f9b8775 Cr-Commit-Position: refs/heads/master@{#414690} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
