Add Cookie.CookieLineCookieValueValidity histogram

net/cookies/parsed_cookie.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Portions of this code based on Mozilla:
 //   (netwerk/cookie/src/nsCookieService.cpp)
 /* ***** BEGIN LICENSE BLOCK *****
  * Version: MPL 1.1/GPL 2.0/LGPL 2.1
  *
  * The contents of this file are subject to the Mozilla Public License Version
@@ skipping 27 matching lines @@
  * decision by deleting the provisions above and replace them with the notice
  * and other provisions required by the GPL or the LGPL. If you do not delete
  * the provisions above, a recipient may use your version of this file under
  * the terms of any one of the MPL, the GPL or the LGPL.
  *
  * ***** END LICENSE BLOCK ***** */
 
 #include "net/cookies/parsed_cookie.h"
 
 #include "base/logging.h"
+#include "base/metrics/histogram.h"

[Ilya Sherman, 2016/08/25 20:04:49]

nit: histogram_macros

[Adam Rice, 2016/08/26 01:36:29]

Fixed, thanks.

 #include "base/strings/string_util.h"
 
 namespace {
 
 const char kPathTokenName[] = "path";
 const char kDomainTokenName[] = "domain";
 const char kExpiresTokenName[] = "expires";
 const char kMaxAgeTokenName[] = "max-age";
 const char kSecureTokenName[] = "secure";
 const char kHttpOnlyTokenName[] = "httponly";
@@ skipping 360 matching lines @@
     if (pair_num != 0)
       pair.first = base::ToLowerASCII(pair.first);
     // Ignore Set-Cookie directives contaning control characters. See
     // http://crbug.com/238041.
     if (!IsValidCookieAttributeValue(pair.first) ||
         !IsValidCookieAttributeValue(pair.second)) {
       pairs_.clear();
       break;
     }
 
+    if (pair_num == 0) {
+      UMA_HISTOGRAM_BOOLEAN("Cookie.CookieLineCookieValueValidity",
+                            IsValidCookieValue(pair.second));
+    }
+
     pairs_.push_back(pair);
 
     // We've processed a token/value pair, we're either at the end of
     // the string or a ValueSeparator like ';', which we want to skip.
     if (it != end)
       ++it;
   }
 }
 
 void ParsedCookie::SetupAttributes() {
@@ skipping 74 matching lines @@
       --*indexes[i];
   }
   pairs_.erase(pairs_.begin() + index);
 }
 
 bool ParsedCookie::IsSameSiteAttributeValid() const {
   return same_site_index_ == 0 || SameSite() != CookieSameSite::DEFAULT_MODE;
 }
 
 }  // namespace