Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Unified Diff: net/cookies/parsed_cookie.cc

Issue 2273633004: Add Cookie.CookieLineCookieValueValidity histogram (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: histogram.h -> histogram_macros.h Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tools/metrics/histograms/histograms.xml » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/cookies/parsed_cookie.cc
diff --git a/net/cookies/parsed_cookie.cc b/net/cookies/parsed_cookie.cc
index 0be70e1565fec6579c369ef13c5dc3d0dd83b4f5..9a2e7d7c342cbcc4a2c0ae61c063b166a7e4f973 100644
--- a/net/cookies/parsed_cookie.cc
+++ b/net/cookies/parsed_cookie.cc
@@ -45,6 +45,7 @@
#include "net/cookies/parsed_cookie.h"
#include "base/logging.h"
+#include "base/metrics/histogram_macros.h"
#include "base/strings/string_util.h"
namespace {
@@ -425,6 +426,11 @@ void ParsedCookie::ParseTokenValuePairs(const std::string& cookie_line) {
break;
}
+ if (pair_num == 0) {
+ UMA_HISTOGRAM_BOOLEAN("Cookie.CookieLineCookieValueValidity",
+ IsValidCookieValue(pair.second));
+ }
+
pairs_.push_back(pair);
// We've processed a token/value pair, we're either at the end of
« no previous file with comments | « no previous file | tools/metrics/histograms/histograms.xml » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698