tools/metrics/histograms/histograms.xml - Issue 2273633004: Add Cookie.CookieLineCookieValueValidity histogram

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/metrics/histograms/histograms.xml

Side-by-side diff isn't available for this file because of its large size.

Issue 2273633004: Add Cookie.CookieLineCookieValueValidity histogram (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: histogram.h -> histogram_macros.h Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/metrics/histograms/histograms.xml

diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml

index 563005187a179030a20017780f96527ad09e1f8b..2dc5355e2ad38cfccd409ad91982cf765a85663c 100644

--- a/tools/metrics/histograms/histograms.xml

+++ b/tools/metrics/histograms/histograms.xml

@@ -6967,6 +6967,17 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.

</summary>

</histogram>

+<histogram name="Cookie.CookieLineCookieValueValidity" enum="BooleanValid">

+ <owner>ricea@chromium.org</owner>

+ <summary>

+ Indicates whether a cookie initialised from a Set-Cookie header value was

+ valid or not. This is only logged after cookies containing control

+ characters have already been rejected, so "Invalid" here means

+ that the cookie contains quotes, commas, backslashes or top-bit-set

+ characters.

+ </summary>

+</histogram>

<owner>estark@chromium.org</owner>

« no previous file with comments | « net/cookies/parsed_cookie.cc ('k') | no next file » | no next file with comments »