Update strings for ash palette and rename options/settings files.

Update strings for ash palette and rename options/settings files.

BUG=616112
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/6546a0d15f138ca519f271833d92757742244a1a
Cr-Commit-Position: refs/heads/master@{#414650}

[jdufault, 2016-08-25 17:58:48]

Description was changed from

==========
Upload final strings.

BUG=
==========

to

==========
Upload final strings.

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[jdufault, 2016-08-25 18:03:12]

Description was changed from

==========
Upload final strings.

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Upload final strings.

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[jdufault, 2016-08-25 18:04:03]

Description was changed from

==========
Upload final strings.

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Update strings for ash palette.

BUG=616112
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[jdufault, 2016-08-25 18:05:01]

jdufault@chromium.org changed reviewers:
+ stevenjb@chromium.org

[jdufault, 2016-08-25 18:06:07]

stevenjb@, PTAL. This CL just changes strings to their final values.

[stevenjb, 2016-08-25 18:27:16]

https://codereview.chromium.org/2273273003/diff/1/ash/ash_strings.grd
File ash/ash_strings.grd (right):

https://codereview.chromium.org/2273273003/diff/1/ash/ash_strings.grd#newcode370
ash/ash_strings.grd:370: <message name="IDS_ASH_PALETTE_CAPTURE_REGION_ACTION"
desc="Title of the capture region action in the palette (a pop-up panel next to
the status tray). This causes a partial screenshot to be taken, where after
clicking the palette is dimissed and the user selects an area of the screen to
take a screenshot of.">
As long as we are moving these and changing the text, can we rename them?
'palette' always makes me think of colors.

https://codereview.chromium.org/2273273003/diff/1/chrome/app/settings_strings...
File chrome/app/settings_strings.grdp (right):

https://codereview.chromium.org/2273273003/diff/1/chrome/app/settings_strings...
chrome/app/settings_strings.grdp:1418: PIN may be easy to guess
Unrelated?

https://codereview.chromium.org/2273273003/diff/1/chrome/app/settings_strings...
chrome/app/settings_strings.grdp:1848: <message name="IDS_OPTIONS_NOTE_TITLE"
desc="Title of the stylus settings (non material-design) page.">
Rename IDS?

https://codereview.chromium.org/2273273003/diff/1/chrome/browser/resources/ch...
File chrome/browser/resources/chromeos/quick_unlock/pin_keyboard.html (right):

https://codereview.chromium.org/2273273003/diff/1/chrome/browser/resources/ch...
chrome/browser/resources/chromeos/quick_unlock/pin_keyboard.html:22: </svg>
Unrelated?

[jdufault, 2016-08-25 21:13:47]

Description was changed from

==========
Update strings for ash palette.

BUG=616112
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Update strings for ash palette and pin unlock.

BUG=616112
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[jdufault, 2016-08-25 21:43:58]

Description was changed from

==========
Update strings for ash palette and pin unlock.

BUG=616112
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Update strings for ash palette and pin unlock, rename options/settings files.

BUG=616112
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[jdufault, 2016-08-25 21:48:02]

I've renamed the settings/options note to stylus as well.

https://codereview.chromium.org/2273273003/diff/1/ash/ash_strings.grd
File ash/ash_strings.grd (right):

https://codereview.chromium.org/2273273003/diff/1/ash/ash_strings.grd#newcode370
ash/ash_strings.grd:370: <message name="IDS_ASH_PALETTE_CAPTURE_REGION_ACTION"
desc="Title of the capture region action in the palette (a pop-up panel next to
the status tray). This causes a partial screenshot to be taken, where after
clicking the palette is dimissed and the user selects an area of the screen to
take a screenshot of.">
On 2016/08/25 18:27:16, stevenjb wrote:
> As long as we are moving these and changing the text, can we rename them?
> 'palette' always makes me think of colors.

Done.

https://codereview.chromium.org/2273273003/diff/1/chrome/app/settings_strings...
File chrome/app/settings_strings.grdp (right):

https://codereview.chromium.org/2273273003/diff/1/chrome/app/settings_strings...
chrome/app/settings_strings.grdp:1418: PIN may be easy to guess
On 2016/08/25 18:27:16, stevenjb wrote:
> Unrelated?

The PIN strings also got changed, so I was updating them in this CL as well. I
can pull it out into a separate CL if you prefer. I've reworked the CL message
to account for these string changes.

https://codereview.chromium.org/2273273003/diff/1/chrome/app/settings_strings...
chrome/app/settings_strings.grdp:1848: <message name="IDS_OPTIONS_NOTE_TITLE"
desc="Title of the stylus settings (non material-design) page.">
On 2016/08/25 18:27:16, stevenjb wrote:
> Rename IDS?

Done.

https://codereview.chromium.org/2273273003/diff/1/chrome/browser/resources/ch...
File chrome/browser/resources/chromeos/quick_unlock/pin_keyboard.html (right):

https://codereview.chromium.org/2273273003/diff/1/chrome/browser/resources/ch...
chrome/browser/resources/chromeos/quick_unlock/pin_keyboard.html:22: </svg>
On 2016/08/25 18:27:16, stevenjb wrote:
> Unrelated?

Yes; I can revert if you prefer.

[stevenjb, 2016-08-25 21:51:34]

https://codereview.chromium.org/2273273003/diff/1/chrome/app/settings_strings...
File chrome/app/settings_strings.grdp (right):

https://codereview.chromium.org/2273273003/diff/1/chrome/app/settings_strings...
chrome/app/settings_strings.grdp:1418: PIN may be easy to guess
On 2016/08/25 21:48:02, jdufault wrote:
> On 2016/08/25 18:27:16, stevenjb wrote:
> > Unrelated?
> 
> The PIN strings also got changed, so I was updating them in this CL as well. I
> can pull it out into a separate CL if you prefer. I've reworked the CL message
> to account for these string changes.

A separate CL would be preferred, since (as far as I am aware) these features
are unrelated, thanks.

[jdufault, 2016-08-25 22:06:04]

On 2016/08/25 21:51:34, stevenjb wrote:
>
https://codereview.chromium.org/2273273003/diff/1/chrome/app/settings_strings...
> File chrome/app/settings_strings.grdp (right):
> 
>
https://codereview.chromium.org/2273273003/diff/1/chrome/app/settings_strings...
> chrome/app/settings_strings.grdp:1418: PIN may be easy to guess
> On 2016/08/25 21:48:02, jdufault wrote:
> > On 2016/08/25 18:27:16, stevenjb wrote:
> > > Unrelated?
> > 
> > The PIN strings also got changed, so I was updating them in this CL as well.
I
> > can pull it out into a separate CL if you prefer. I've reworked the CL
message
> > to account for these string changes.
> 
> A separate CL would be preferred, since (as far as I am aware) these features
> are unrelated, thanks.

Done.

[jdufault, 2016-08-25 22:06:40]

Description was changed from

==========
Update strings for ash palette and pin unlock, rename options/settings files.

BUG=616112
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Update strings for ash palette and rename options/settings files.

BUG=616112
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[stevenjb, 2016-08-25 22:39:14]

lgtm, thanks! (This will make the code much more searchable as we develop and
maintain the feature).

[jdufault, 2016-08-25 23:11:48]

On 2016/08/25 22:39:14, stevenjb wrote:
> lgtm, thanks! (This will make the code much more searchable as we develop and
> maintain the feature).

Once work on m54 settles down I plan on doing a big rename :)

[jdufault, 2016-08-25 23:12:03]

The CQ bit was checked by jdufault@chromium.org

[commit-bot: I haz the power, 2016-08-25 23:13:04]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-26 00:58:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-26 00:58:03]

Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[jdufault, 2016-08-26 01:31:48]

The CQ bit was checked by jdufault@chromium.org

[jdufault, 2016-08-26 01:31:48]

The patchset sent to the CQ was uploaded after l-g-t-m from
stevenjb@chromium.org
Link to the patchset: https://codereview.chromium.org/2273273003/#ps60001
(title: "Rebase")

[commit-bot: I haz the power, 2016-08-26 01:32:13]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jdufault, 2016-08-26 01:52:26]

The CQ bit was unchecked by jdufault@chromium.org

[jdufault, 2016-08-26 01:57:31]

The CQ bit was checked by jdufault@chromium.org

[jdufault, 2016-08-26 01:57:32]

The patchset sent to the CQ was uploaded after l-g-t-m from
stevenjb@chromium.org
Link to the patchset: https://codereview.chromium.org/2273273003/#ps80001
(title: "A few more string changes")

[commit-bot: I haz the power, 2016-08-26 01:57:58]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-26 04:28:15]

Description was changed from

==========
Update strings for ash palette and rename options/settings files.

BUG=616112
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Update strings for ash palette and rename options/settings files.

BUG=616112
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[commit-bot: I haz the power, 2016-08-26 04:28:16]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-08-26 04:30:34]

Description was changed from

==========
Update strings for ash palette and rename options/settings files.

BUG=616112
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Update strings for ash palette and rename options/settings files.

BUG=616112
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/6546a0d15f138ca519f271833d92757742244a1a
Cr-Commit-Position: refs/heads/master@{#414650}
==========

[commit-bot: I haz the power, 2016-08-26 04:30:35]

Patchset 5 (id:??) landed as
https://crrev.com/6546a0d15f138ca519f271833d92757742244a1a
Cr-Commit-Position: refs/heads/master@{#414650}