Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(116)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2258553004: Add pref to enable/disable palette tray. (Closed)

Created:
4 years, 4 months ago by jdufault
Modified:
4 years, 3 months ago
Reviewers:
stevenjb, oshima
CC:
chromium-reviews, dbeam+watch-options_chromium.org, extensions-reviews_chromium.org, michaelpg+watch-options_chromium.org, sadrul, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, kalyank, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org, davemoore+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@lkgr
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add pref to enable/disable palette tray. BUG=616112 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/fbe81f60c9b6f5093a3bd226a60aec1c6c4e992e Cr-Commit-Position: refs/heads/master@{#414733}

Patch Set 1 : Initial upload #

Total comments: 12

Patch Set 2 : Address comments #

Patch Set 3 : Rebase #

Patch Set 4 : Rebase #

Patch Set 5 : Rebase, make pref synced with final name #

Patch Set 6 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+227 lines, -38 lines) Patch
M ash/common/palette_delegate.h View 1 2 3 4 2 chunks +10 lines, -0 lines 0 comments Download
M ash/common/session/session_state_observer.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M ash/common/system/chromeos/palette/palette_tray.h View 1 2 3 4 5 2 chunks +9 lines, -1 line 0 comments Download
M ash/common/system/chromeos/palette/palette_tray.cc View 1 2 3 4 5 4 chunks +16 lines, -5 lines 0 comments Download
M ash/common/system/chromeos/palette/palette_utils.h View 1 chunk +3 lines, -2 lines 0 comments Download
M ash/common/system/chromeos/palette/palette_utils.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/common/system/status_area_widget.cc View 1 2 4 chunks +9 lines, -4 lines 0 comments Download
M ash/common/test/test_palette_delegate.h View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
M ash/common/test/test_palette_delegate.cc View 1 2 3 1 chunk +6 lines, -0 lines 0 comments Download
M ash/shell/shell_delegate_impl.cc View 1 2 3 4 5 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/note_taking_app_utils.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/preferences.cc View 1 2 3 4 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/extensions/api/settings_private/prefs_util.cc View 1 2 3 4 1 chunk +6 lines, -2 lines 0 comments Download
M chrome/browser/resources/options/chromeos/stylus_overlay.html View 1 2 3 4 5 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/browser/resources/settings/device_page/stylus.html View 1 2 3 4 5 1 chunk +7 lines, -0 lines 0 comments Download
M chrome/browser/ui/ash/palette_delegate_chromeos.h View 1 2 3 2 chunks +36 lines, -2 lines 0 comments Download
M chrome/browser/ui/ash/palette_delegate_chromeos.cc View 1 2 3 4 3 chunks +89 lines, -11 lines 0 comments Download
M chrome/browser/ui/webui/options/chromeos/options_stylus_handler.cc View 1 2 3 4 5 1 chunk +5 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc View 1 2 3 4 5 1 chunk +4 lines, -5 lines 0 comments Download
M chrome/browser/ui/webui/settings/md_settings_ui.cc View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/pref_names.h View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/pref_names.cc View 1 2 3 4 1 chunk +3 lines, -0 lines 0 comments Download

Depends on Patchset:

Issue 2273273003 Patch 80001

Dependent Patchsets:

Issue 2276233002 Patch 100001

Messages

Total messages: 55 (42 generated)
jdufault
stevenjb@, PTAL. Thanks!
4 years, 4 months ago (2016-08-18 23:04:40 UTC) #13
stevenjb
https://codereview.chromium.org/2258553004/diff/20001/ash/common/system/chromeos/palette/palette_tray.h File ash/common/system/chromeos/palette/palette_tray.h (right): https://codereview.chromium.org/2258553004/diff/20001/ash/common/system/chromeos/palette/palette_tray.h#newcode98 ash/common/system/chromeos/palette/palette_tray.h:98: std::unique_ptr<PaletteDelegate::EnableListenerSubscription> palette_enabled_; This is a confusing variable name, I ...
4 years, 4 months ago (2016-08-23 17:36:42 UTC) #14
jdufault
https://codereview.chromium.org/2258553004/diff/20001/ash/common/system/chromeos/palette/palette_tray.h File ash/common/system/chromeos/palette/palette_tray.h (right): https://codereview.chromium.org/2258553004/diff/20001/ash/common/system/chromeos/palette/palette_tray.h#newcode98 ash/common/system/chromeos/palette/palette_tray.h:98: std::unique_ptr<PaletteDelegate::EnableListenerSubscription> palette_enabled_; On 2016/08/23 17:36:41, stevenjb wrote: > This ...
4 years, 4 months ago (2016-08-23 22:49:56 UTC) #15
stevenjb
lgtm
4 years, 4 months ago (2016-08-23 23:05:03 UTC) #18
jdufault
oshima@, PTAL at ash/common/session and ash/common/palette_delegate.h. Thanks!
4 years, 4 months ago (2016-08-24 00:07:17 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2258553004/100001
4 years, 3 months ago (2016-08-26 00:37:58 UTC) #37
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/246651)
4 years, 3 months ago (2016-08-26 00:45:14 UTC) #39
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2258553004/120001
4 years, 3 months ago (2016-08-26 07:29:47 UTC) #46
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/246856)
4 years, 3 months ago (2016-08-26 07:36:43 UTC) #48
oshima
lgtm
4 years, 3 months ago (2016-08-26 15:47:51 UTC) #49
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2258553004/120001
4 years, 3 months ago (2016-08-26 16:46:29 UTC) #51
commit-bot: I haz the power
Committed patchset #6 (id:120001)
4 years, 3 months ago (2016-08-26 16:51:29 UTC) #53
commit-bot: I haz the power
4 years, 3 months ago (2016-08-26 16:56:46 UTC) #55
Message was sent while issue was closed. 
Patchset 6 (id:??) landed as
https://crrev.com/fbe81f60c9b6f5093a3bd226a60aec1c6c4e992e
Cr-Commit-Position: refs/heads/master@{#414733}

Powered by Google App Engine
This is Rietveld 408576698