ash: Move alignment and autohide behavior from Shelf to WmShelf

ash: Move alignment and autohide behavior from Shelf to WmShelf

This is a step toward replacing Shelf with WmShelf, which has a more sensible
lifetime. It does not change shelf behavior.

* Migrate the various getters and setters.
* Before the shelf is constructed (after login) default the alignment to
bottom-locked. After construction default to bottom. This is weird, but matches
what we had before.
* Add Shelf::wm_shelf() and use it in pieces of code that we know we'll have to
refactor anyway (chrome, some ash/wm pieces we're not converting).
* Move ShelfView::OnShelfAlignmentChanged() call into ShelfWidget. In general
I'm trying to reduce outside access into ShelfView.
* Convert Shelf* to WmShelf* where possible in tests.
* Make AshTestBase::GetPrimaryShelf() public so it can be used in test utility
functions outside of test classes.

BUG=615502
TEST=ash_unittests, chrome unit_tests
TBR=derat@chromium.org

Committed: https://crrev.com/a18fb174daa8e0c2770ce8f71807856de55f032c
Cr-Commit-Position: refs/heads/master@{#413987}

[James Cook, 2016-08-23 23:35:56]

The CQ bit was checked by jamescook@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-23 23:36:32]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[James Cook, 2016-08-23 23:36:47]

jamescook@chromium.org changed reviewers:
+ msw@chromium.org

[James Cook, 2016-08-23 23:36:48]

msw, please take a look.

[msw, 2016-08-24 00:18:59]

lgtm with nits/qs.

https://codereview.chromium.org/2272793005/diff/20001/ash/common/shelf/wm_she...
File ash/common/shelf/wm_shelf.cc (right):

https://codereview.chromium.org/2272793005/diff/20001/ash/common/shelf/wm_she...
ash/common/shelf/wm_shelf.cc:23: shelf_locking_manager_.reset(new
ShelfLockingManager(this));
Should this DCHECK that the ShelfLayoutManager is valid, since calls to
SetAlignment rely on a valid layout manager and widget?

https://codereview.chromium.org/2272793005/diff/20001/ash/common/shelf/wm_she...
File ash/common/shelf/wm_shelf.h (right):

https://codereview.chromium.org/2272793005/diff/20001/ash/common/shelf/wm_she...
ash/common/shelf/wm_shelf.h:148: std::unique_ptr<ShelfLockingManager>
shelf_locking_manager_;
Too bad this needs to be a unique_ptr now. We could avoid that if its
SetAlignment calls didn't occur outside the lifetime of the shelf
widget/layout_manager, or if WmShelf handled those cases gracefully, but w/e.

https://codereview.chromium.org/2272793005/diff/20001/chrome/browser/ui/ash/m...
File
chrome/browser/ui/ash/multi_user/multi_user_window_manager_chromeos_unittest.cc
(right):

https://codereview.chromium.org/2272793005/diff/20001/chrome/browser/ui/ash/m...
chrome/browser/ui/ash/multi_user/multi_user_window_manager_chromeos_unittest.cc:1324:
GetPrimaryShelf()->SetAutoHideBehavior(SHELF_AUTO_HIDE_BEHAVIOR_NEVER);
nit: use |shelf|

[commit-bot: I haz the power, 2016-08-24 00:26:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-24 00:26:39]

Dry run: This issue passed the CQ dry run.

[James Cook, 2016-08-24 04:19:08]

Thanks for the quick review.

https://codereview.chromium.org/2272793005/diff/20001/ash/common/shelf/wm_she...
File ash/common/shelf/wm_shelf.cc (right):

https://codereview.chromium.org/2272793005/diff/20001/ash/common/shelf/wm_she...
ash/common/shelf/wm_shelf.cc:23: shelf_locking_manager_.reset(new
ShelfLockingManager(this));
On 2016/08/24 00:18:59, msw wrote:
> Should this DCHECK that the ShelfLayoutManager is valid, since calls to
> SetAlignment rely on a valid layout manager and widget?

Good idea. Done.

https://codereview.chromium.org/2272793005/diff/20001/chrome/browser/ui/ash/m...
File
chrome/browser/ui/ash/multi_user/multi_user_window_manager_chromeos_unittest.cc
(right):

https://codereview.chromium.org/2272793005/diff/20001/chrome/browser/ui/ash/m...
chrome/browser/ui/ash/multi_user/multi_user_window_manager_chromeos_unittest.cc:1324:
GetPrimaryShelf()->SetAutoHideBehavior(SHELF_AUTO_HIDE_BEHAVIOR_NEVER);
On 2016/08/24 00:18:59, msw wrote:
> nit: use |shelf|

Done.

[James Cook, 2016-08-24 04:21:04]

Description was changed from

==========
ash: Move alignment and autohide behavior from Shelf to WmShelf

This is a step toward replacing Shelf with WmShelf, which has a more sensible
lifetime. It does not change shelf behavior.

* Migrate the various getters and setters.
* Before the shelf is constructed (after login) default the alignment to
bottom-locked. After construction default to bottom. This is weird, but matches
what we had before.
* Add Shelf::wm_shelf() and use it in pieces of code that we know we'll have to
refactor anyway (chrome, some ash/wm pieces we're not converting).
* Move ShelfView::OnShelfAlignmentChanged() call into ShelfWidget. In general
I'm trying to reduce outside access into ShelfView.
* Convert Shelf* to WmShelf* where possible in tests.
* Make AshTestBase::GetPrimaryShelf() public so it can be used in test utility
functions outside of test classes.

BUG=615502
TEST=ash_unittests, chrome unit_tests
==========

to

==========
ash: Move alignment and autohide behavior from Shelf to WmShelf

This is a step toward replacing Shelf with WmShelf, which has a more sensible
lifetime. It does not change shelf behavior.

* Migrate the various getters and setters.
* Before the shelf is constructed (after login) default the alignment to
bottom-locked. After construction default to bottom. This is weird, but matches
what we had before.
* Add Shelf::wm_shelf() and use it in pieces of code that we know we'll have to
refactor anyway (chrome, some ash/wm pieces we're not converting).
* Move ShelfView::OnShelfAlignmentChanged() call into ShelfWidget. In general
I'm trying to reduce outside access into ShelfView.
* Convert Shelf* to WmShelf* where possible in tests.
* Make AshTestBase::GetPrimaryShelf() public so it can be used in test utility
functions outside of test classes.

BUG=615502
TEST=ash_unittests, chrome unit_tests
TBR=derat@chromium.org
==========

[James Cook, 2016-08-24 04:21:39]

jamescook@chromium.org changed reviewers:
+ derat@chromium.org

[James Cook, 2016-08-24 04:21:40]

TBR derat for mechanical changes to chrome/browser/chromeos

[James Cook, 2016-08-24 04:22:01]

The CQ bit was checked by jamescook@chromium.org

[James Cook, 2016-08-24 04:22:02]

The patchset sent to the CQ was uploaded after l-g-t-m from msw@chromium.org
Link to the patchset: https://codereview.chromium.org/2272793005/#ps40001
(title: "review comments")

[commit-bot: I haz the power, 2016-08-24 04:22:41]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Daniel Erat, 2016-08-24 04:33:16]

lgtm for c/b/chromeos

[commit-bot: I haz the power, 2016-08-24 05:30:03]

Description was changed from

==========
ash: Move alignment and autohide behavior from Shelf to WmShelf

This is a step toward replacing Shelf with WmShelf, which has a more sensible
lifetime. It does not change shelf behavior.

* Migrate the various getters and setters.
* Before the shelf is constructed (after login) default the alignment to
bottom-locked. After construction default to bottom. This is weird, but matches
what we had before.
* Add Shelf::wm_shelf() and use it in pieces of code that we know we'll have to
refactor anyway (chrome, some ash/wm pieces we're not converting).
* Move ShelfView::OnShelfAlignmentChanged() call into ShelfWidget. In general
I'm trying to reduce outside access into ShelfView.
* Convert Shelf* to WmShelf* where possible in tests.
* Make AshTestBase::GetPrimaryShelf() public so it can be used in test utility
functions outside of test classes.

BUG=615502
TEST=ash_unittests, chrome unit_tests
TBR=derat@chromium.org
==========

to

==========
ash: Move alignment and autohide behavior from Shelf to WmShelf

This is a step toward replacing Shelf with WmShelf, which has a more sensible
lifetime. It does not change shelf behavior.

* Migrate the various getters and setters.
* Before the shelf is constructed (after login) default the alignment to
bottom-locked. After construction default to bottom. This is weird, but matches
what we had before.
* Add Shelf::wm_shelf() and use it in pieces of code that we know we'll have to
refactor anyway (chrome, some ash/wm pieces we're not converting).
* Move ShelfView::OnShelfAlignmentChanged() call into ShelfWidget. In general
I'm trying to reduce outside access into ShelfView.
* Convert Shelf* to WmShelf* where possible in tests.
* Make AshTestBase::GetPrimaryShelf() public so it can be used in test utility
functions outside of test classes.

BUG=615502
TEST=ash_unittests, chrome unit_tests
TBR=derat@chromium.org
==========

[commit-bot: I haz the power, 2016-08-24 05:30:05]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-08-24 05:32:08]

Description was changed from

==========
ash: Move alignment and autohide behavior from Shelf to WmShelf

This is a step toward replacing Shelf with WmShelf, which has a more sensible
lifetime. It does not change shelf behavior.

* Migrate the various getters and setters.
* Before the shelf is constructed (after login) default the alignment to
bottom-locked. After construction default to bottom. This is weird, but matches
what we had before.
* Add Shelf::wm_shelf() and use it in pieces of code that we know we'll have to
refactor anyway (chrome, some ash/wm pieces we're not converting).
* Move ShelfView::OnShelfAlignmentChanged() call into ShelfWidget. In general
I'm trying to reduce outside access into ShelfView.
* Convert Shelf* to WmShelf* where possible in tests.
* Make AshTestBase::GetPrimaryShelf() public so it can be used in test utility
functions outside of test classes.

BUG=615502
TEST=ash_unittests, chrome unit_tests
TBR=derat@chromium.org
==========

to

==========
ash: Move alignment and autohide behavior from Shelf to WmShelf

This is a step toward replacing Shelf with WmShelf, which has a more sensible
lifetime. It does not change shelf behavior.

* Migrate the various getters and setters.
* Before the shelf is constructed (after login) default the alignment to
bottom-locked. After construction default to bottom. This is weird, but matches
what we had before.
* Add Shelf::wm_shelf() and use it in pieces of code that we know we'll have to
refactor anyway (chrome, some ash/wm pieces we're not converting).
* Move ShelfView::OnShelfAlignmentChanged() call into ShelfWidget. In general
I'm trying to reduce outside access into ShelfView.
* Convert Shelf* to WmShelf* where possible in tests.
* Make AshTestBase::GetPrimaryShelf() public so it can be used in test utility
functions outside of test classes.

BUG=615502
TEST=ash_unittests, chrome unit_tests
TBR=derat@chromium.org

Committed: https://crrev.com/a18fb174daa8e0c2770ce8f71807856de55f032c
Cr-Commit-Position: refs/heads/master@{#413987}
==========

[commit-bot: I haz the power, 2016-08-24 05:32:10]

Patchset 3 (id:??) landed as
https://crrev.com/a18fb174daa8e0c2770ce8f71807856de55f032c
Cr-Commit-Position: refs/heads/master@{#413987}