chrome/browser/chromeos/first_run/steps/tray_step.cc - Issue 2272793005: ash: Move alignment and autohide behavior from Shelf to WmShelf

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/first_run/steps/tray_step.cc

Issue 2272793005: ash: Move alignment and autohide behavior from Shelf to WmShelf (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: review comments Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « ash/wm/workspace_controller_unittest.cc ('k') | chrome/browser/chromeos/login/supervised/supervised_user_creation_screen.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/first_run/steps/tray_step.cc

diff --git a/chrome/browser/chromeos/first_run/steps/tray_step.cc b/chrome/browser/chromeos/first_run/steps/tray_step.cc

index b6305ca3cc99393b3d1e91d105ed50b44d71ca93..4e4192c7e05a5dfa03e1842566333420307cb9c1 100644

--- a/chrome/browser/chromeos/first_run/steps/tray_step.cc

+++ b/chrome/browser/chromeos/first_run/steps/tray_step.cc

@@ -5,6 +5,7 @@

#include "chrome/browser/chromeos/first_run/steps/tray_step.h"

#include "ash/common/shelf/shelf.h"

+#include "ash/common/shelf/wm_shelf.h"

#include "ash/first_run/first_run_helper.h"

#include "base/i18n/rtl.h"

#include "chrome/browser/chromeos/first_run/step_names.h"

@@ -27,7 +28,8 @@ void TrayStep::DoShow() {

bounds.height());

FirstRunActor::StepPosition position;

position.SetTop(bounds.y());

- ash::ShelfAlignment alignment = ash::Shelf::ForPrimaryDisplay()->alignment();

+ ash::ShelfAlignment alignment =

+ ash::Shelf::ForPrimaryDisplay()->wm_shelf()->alignment();

if ((!base::i18n::IsRTL() && alignment != ash::SHELF_ALIGNMENT_LEFT) ||

alignment == ash::SHELF_ALIGNMENT_RIGHT)

position.SetRight(GetOverlaySize().width() - bounds.x());