Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2461)

Unified Diff: ash/wm/panels/panel_window_resizer_unittest.cc

Issue 2272793005: ash: Move alignment and autohide behavior from Shelf to WmShelf (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: review comments Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ash/wm/panels/panel_layout_manager_unittest.cc ('k') | ash/wm/window_animations.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ash/wm/panels/panel_window_resizer_unittest.cc
diff --git a/ash/wm/panels/panel_window_resizer_unittest.cc b/ash/wm/panels/panel_window_resizer_unittest.cc
index 783442fb3fc9261f822dba84452909f896b95833..02a714be61adc4ed609649c7b29b49c3a0a63875 100644
--- a/ash/wm/panels/panel_window_resizer_unittest.cc
+++ b/ash/wm/panels/panel_window_resizer_unittest.cc
@@ -5,11 +5,11 @@
#include "ash/common/wm/panels/panel_window_resizer.h"
#include "ash/aura/wm_window_aura.h"
-#include "ash/common/shelf/shelf.h"
#include "ash/common/shelf/shelf_layout_manager.h"
#include "ash/common/shelf/shelf_model.h"
#include "ash/common/shelf/shelf_types.h"
#include "ash/common/shelf/shelf_widget.h"
+#include "ash/common/shelf/wm_shelf.h"
#include "ash/common/shell_window_ids.h"
#include "ash/common/wm/window_state.h"
#include "ash/common/wm/wm_event.h"
@@ -238,7 +238,7 @@ TEST_F(PanelWindowResizerTest, PanelDetachReattachLeft) {
if (!SupportsHostWindowResize())
return;
- Shelf::ForPrimaryDisplay()->SetAlignment(SHELF_ALIGNMENT_LEFT);
+ GetPrimaryShelf()->SetAlignment(SHELF_ALIGNMENT_LEFT);
std::unique_ptr<aura::Window> window(CreatePanelWindow(gfx::Point(0, 0)));
DetachReattachTest(window.get(), 1, 0);
}
@@ -247,7 +247,7 @@ TEST_F(PanelWindowResizerTest, PanelDetachReattachRight) {
if (!SupportsHostWindowResize())
return;
- Shelf::ForPrimaryDisplay()->SetAlignment(SHELF_ALIGNMENT_RIGHT);
+ GetPrimaryShelf()->SetAlignment(SHELF_ALIGNMENT_RIGHT);
std::unique_ptr<aura::Window> window(CreatePanelWindow(gfx::Point(0, 0)));
DetachReattachTest(window.get(), -1, 0);
}
@@ -267,7 +267,7 @@ TEST_F(PanelWindowResizerTest, DetachThenHideShelf) {
// Hide the shelf. This minimizes all attached windows but should ignore
// the dragged window.
- Shelf* shelf = RootWindowController::ForWindow(window.get())->GetShelf();
+ WmShelf* shelf = GetPrimaryShelf();
shelf->SetAutoHideBehavior(SHELF_AUTO_HIDE_ALWAYS_HIDDEN);
shelf->shelf_layout_manager()->UpdateVisibilityState();
RunAllPendingInMessageLoop();
@@ -486,7 +486,7 @@ TEST_F(PanelWindowResizerTest, DragReordersPanelsVertical) {
if (!SupportsHostWindowResize())
return;
- Shelf::ForPrimaryDisplay()->SetAlignment(SHELF_ALIGNMENT_LEFT);
+ GetPrimaryShelf()->SetAlignment(SHELF_ALIGNMENT_LEFT);
DragAlongShelfReorder(0, -1);
}
« no previous file with comments | « ash/wm/panels/panel_layout_manager_unittest.cc ('k') | ash/wm/window_animations.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698