Dry run: Try jobs failed on following builders: linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_compile_dbg_ng/builds/146787)
4 years, 3 months ago
(2016-08-25 14:08:26 UTC)
#10
My comments are nits, so you don't need my LG. https://codereview.chromium.org/2272313003/diff/40001/third_party/WebKit/Source/bindings/core/v8/ArrayValue.cpp File third_party/WebKit/Source/bindings/core/v8/ArrayValue.cpp (right): https://codereview.chromium.org/2272313003/diff/40001/third_party/WebKit/Source/bindings/core/v8/ArrayValue.cpp#newcode42 ...
4 years, 3 months ago
(2016-08-25 15:31:18 UTC)
#12
Dry run: Try jobs failed on following builders: linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_asan_rel_ng/builds/217409)
4 years, 3 months ago
(2016-08-29 07:57:02 UTC)
#18
Dry run: Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/131844)
4 years, 3 months ago
(2016-08-29 10:55:07 UTC)
#22
4 years, 3 months ago
(2016-08-30 08:14:31 UTC)
#31
Message was sent while issue was closed.
Committed patchset #7 (id:120001)
commit-bot: I haz the power
Description was changed from ========== binding: Makes ExceptionState STACK_ALLOCATED(). Since we're going to make ExceptionStates ...
4 years, 3 months ago
(2016-08-30 08:16:45 UTC)
#32
Message was sent while issue was closed.
Description was changed from
==========
binding: Makes ExceptionState STACK_ALLOCATED().
Since we're going to make ExceptionStates scope-like objects at
http://crrev.com/2272613003 , ExceptionState should be
STACK_ALLOCATED().
BUG=
==========
to
==========
binding: Makes ExceptionState STACK_ALLOCATED().
Since we're going to make ExceptionStates scope-like objects at
http://crrev.com/2272613003 , ExceptionState should be
STACK_ALLOCATED().
BUG=
Committed: https://crrev.com/816254910aa039c21e728a7ff5d518174f9a2dfc
Cr-Commit-Position: refs/heads/master@{#415241}
==========
commit-bot: I haz the power
Patchset 7 (id:??) landed as https://crrev.com/816254910aa039c21e728a7ff5d518174f9a2dfc Cr-Commit-Position: refs/heads/master@{#415241}
4 years, 3 months ago
(2016-08-30 08:16:46 UTC)
#33
Issue 2272313003: binding: Makes ExceptionState STACK_ALLOCATED().
(Closed)
Created 4 years, 3 months ago by Yuki
Modified 4 years, 3 months ago
Reviewers: haraken, bashi, peria
Base URL:
Comments: 4