Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Issue 2272313003: binding: Makes ExceptionState STACK_ALLOCATED(). (Closed)

Created:
4 years, 3 months ago by Yuki
Modified:
4 years, 3 months ago
Reviewers:
haraken, peria, bashi
CC:
chromium-reviews, blink-reviews, blink-reviews-bindings_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

binding: Makes ExceptionState STACK_ALLOCATED(). Since we're going to make ExceptionStates scope-like objects at http://crrev.com/2272613003 , ExceptionState should be STACK_ALLOCATED(). BUG= Committed: https://crrev.com/816254910aa039c21e728a7ff5d518174f9a2dfc Cr-Commit-Position: refs/heads/master@{#415241}

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : . #

Total comments: 4

Patch Set 4 : Synced. #

Patch Set 5 : Fixed webkit_unit_tests. #

Patch Set 6 : Fixed AnimationAnimationTest.FinishDoesNothingWithPlaybackRateZero. #

Patch Set 7 : Synced. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+98 lines, -203 lines) Patch
M third_party/WebKit/Source/bindings/core/v8/ArrayValue.h View 1 2 3 4 3 chunks +6 lines, -13 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/ArrayValue.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/Dictionary.h View 1 4 chunks +13 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/Dictionary.cpp View 5 chunks +5 lines, -49 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/ExceptionState.h View 1 2 3 4 5 6 4 chunks +1 line, -9 lines 0 comments Download
D third_party/WebKit/Source/bindings/core/v8/OnStackObjectChecker.h View 1 2 1 chunk +0 lines, -39 lines 0 comments Download
D third_party/WebKit/Source/bindings/core/v8/OnStackObjectChecker.cpp View 1 2 1 chunk +0 lines, -34 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/v8.gypi View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/animation/AnimationInputHelpersTest.cpp View 1 2 3 4 3 chunks +6 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/animation/AnimationTest.cpp View 1 2 3 4 5 10 chunks +10 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/animation/KeyframeEffectTest.cpp View 1 2 3 4 10 chunks +23 lines, -13 lines 0 comments Download
M third_party/WebKit/Source/modules/cachestorage/CacheTest.cpp View 1 2 3 4 20 chunks +30 lines, -29 lines 0 comments Download

Messages

Total messages: 33 (25 generated)
Yuki
Could you guys review this CL?
4 years, 3 months ago (2016-08-25 13:41:30 UTC) #8
peria
My comments are nits, so you don't need my LG. https://codereview.chromium.org/2272313003/diff/40001/third_party/WebKit/Source/bindings/core/v8/ArrayValue.cpp File third_party/WebKit/Source/bindings/core/v8/ArrayValue.cpp (right): https://codereview.chromium.org/2272313003/diff/40001/third_party/WebKit/Source/bindings/core/v8/ArrayValue.cpp#newcode42 ...
4 years, 3 months ago (2016-08-25 15:31:18 UTC) #12
bashi
lgtm once AnimationTest build failure is fixed.
4 years, 3 months ago (2016-08-25 23:13:54 UTC) #13
haraken
LGTM
4 years, 3 months ago (2016-08-26 01:08:51 UTC) #14
Yuki
https://codereview.chromium.org/2272313003/diff/40001/third_party/WebKit/Source/bindings/core/v8/ArrayValue.cpp File third_party/WebKit/Source/bindings/core/v8/ArrayValue.cpp (right): https://codereview.chromium.org/2272313003/diff/40001/third_party/WebKit/Source/bindings/core/v8/ArrayValue.cpp#newcode42 third_party/WebKit/Source/bindings/core/v8/ArrayValue.cpp:42: return blink::isUndefinedOrNull(m_array); On 2016/08/25 15:31:18, peria wrote: > We ...
4 years, 3 months ago (2016-08-30 06:09:07 UTC) #27
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2272313003/120001
4 years, 3 months ago (2016-08-30 06:09:54 UTC) #30
commit-bot: I haz the power
Committed patchset #7 (id:120001)
4 years, 3 months ago (2016-08-30 08:14:31 UTC) #31
commit-bot: I haz the power
4 years, 3 months ago (2016-08-30 08:16:46 UTC) #33
Message was sent while issue was closed.
Patchset 7 (id:??) landed as
https://crrev.com/816254910aa039c21e728a7ff5d518174f9a2dfc
Cr-Commit-Position: refs/heads/master@{#415241}

Powered by Google App Engine
This is Rietveld 408576698