Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Unified Diff: third_party/WebKit/Source/bindings/core/v8/ExceptionState.h

Issue 2272313003: binding: Makes ExceptionState STACK_ALLOCATED(). (Closed)
Patch Set: Synced. Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/bindings/core/v8/ExceptionState.h
diff --git a/third_party/WebKit/Source/bindings/core/v8/ExceptionState.h b/third_party/WebKit/Source/bindings/core/v8/ExceptionState.h
index 357198b0c8082f1eb36d10ed1db9f2af622f8dc8..e7858a49d4e07cdd2ef41f869b1277519bdba00e 100644
--- a/third_party/WebKit/Source/bindings/core/v8/ExceptionState.h
+++ b/third_party/WebKit/Source/bindings/core/v8/ExceptionState.h
@@ -31,7 +31,6 @@
#ifndef ExceptionState_h
#define ExceptionState_h
-#include "bindings/core/v8/OnStackObjectChecker.h"
#include "bindings/core/v8/ScopedPersistent.h"
#include "bindings/core/v8/ScriptPromise.h"
#include "bindings/core/v8/V8ThrowException.h"
@@ -51,8 +50,8 @@ class ScriptState;
// with an option to cancel it. An exception message may be auto-generated.
// You can convert an exception to a reject promise.
class CORE_EXPORT ExceptionState {
+ STACK_ALLOCATED();
WTF_MAKE_NONCOPYABLE(ExceptionState);
- USING_FAST_MALLOC(ExceptionState);
public:
enum ContextType {
ConstructionContext,
@@ -131,10 +130,6 @@ public:
const char* propertyName() const { return m_propertyName; }
const char* interfaceName() const { return m_interfaceName; }
-#if ENABLE(ASSERT)
- OnStackObjectChecker& getOnStackObjectChecker() { return m_onStackObjectChecker; }
-#endif
-
protected:
// An ExceptionCode for the case that an exception is rethrown. In that
// case, we cannot determine an exception code.
@@ -153,9 +148,6 @@ private:
// The exception is empty when it was thrown through TrackExceptionState.
ScopedPersistent<v8::Value> m_exception;
v8::Isolate* m_isolate;
-#if ENABLE(ASSERT)
- OnStackObjectChecker m_onStackObjectChecker;
-#endif
};
// NonThrowableExceptionState never allow call sites to throw an exception.

Powered by Google App Engine
This is Rietveld 408576698