binding: Makes ExceptionState STACK_ALLOCATED().

third_party/WebKit/Source/core/animation/KeyframeEffectTest.cpp

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "core/animation/KeyframeEffect.h"
 
 #include "bindings/core/v8/Dictionary.h"
 #include "bindings/core/v8/DictionarySequenceOrDictionary.h"
 #include "bindings/core/v8/V8BindingForTesting.h"
 #include "bindings/core/v8/V8KeyframeEffectOptions.h"
@@ skipping 20 matching lines @@
 
         document().animationClock().resetTimeForTesting(document().timeline().zeroTime());
         document().documentElement()->appendChild(element.get());
         EXPECT_EQ(0, document().timeline().currentTime());
     }
 
     Document& document() const { return pageHolder->document(); }
 
     std::unique_ptr<DummyPageHolder> pageHolder;
     Persistent<Element> element;
-    TrackExceptionState exceptionState;
 };
 
 class AnimationKeyframeEffectV8Test : public KeyframeEffectTest {
 protected:
     template<typename T>
-    static KeyframeEffect* createAnimation(Element* element, Vector<Dictionary> keyframeDictionaryVector, T timingInput, ExceptionState& exceptionState)
+    static KeyframeEffect* createAnimation(Element* element, Vector<Dictionary> keyframeDictionaryVector, T timingInput)
     {
+        NonThrowableExceptionState exceptionState;
         return KeyframeEffect::create(nullptr, element, DictionarySequenceOrDictionary::fromDictionarySequence(keyframeDictionaryVector), timingInput, exceptionState);
     }
-    static KeyframeEffect* createAnimation(Element* element, Vector<Dictionary> keyframeDictionaryVector, ExceptionState& exceptionState)
+    static KeyframeEffect* createAnimation(Element* element, Vector<Dictionary> keyframeDictionaryVector)
     {
+        NonThrowableExceptionState exceptionState;
         return KeyframeEffect::create(nullptr, element, DictionarySequenceOrDictionary::fromDictionarySequence(keyframeDictionaryVector), exceptionState);
     }
 };
 
 TEST_F(AnimationKeyframeEffectV8Test, CanCreateAnAnimation)
 {
     V8TestingScope scope;
     Vector<Dictionary> jsKeyframes;
     v8::Local<v8::Object> keyframe1 = v8::Object::New(scope.isolate());
     v8::Local<v8::Object> keyframe2 = v8::Object::New(scope.isolate());
 
     setV8ObjectPropertyAsString(scope.isolate(), keyframe1, "width", "100px");
     setV8ObjectPropertyAsString(scope.isolate(), keyframe1, "offset", "0");
     setV8ObjectPropertyAsString(scope.isolate(), keyframe1, "easing", "ease-in-out");
     setV8ObjectPropertyAsString(scope.isolate(), keyframe2, "width", "0px");
     setV8ObjectPropertyAsString(scope.isolate(), keyframe2, "offset", "1");
     setV8ObjectPropertyAsString(scope.isolate(), keyframe2, "easing", "cubic-bezier(1, 1, 0.3, 0.3)");
 
-    jsKeyframes.append(Dictionary(keyframe1, scope.isolate(), exceptionState));
-    jsKeyframes.append(Dictionary(keyframe2, scope.isolate(), exceptionState));
+    jsKeyframes.append(Dictionary(scope.isolate(), keyframe1));
+    jsKeyframes.append(Dictionary(scope.isolate(), keyframe2));
 
     String value1;
     ASSERT_TRUE(DictionaryHelper::get(jsKeyframes[0], "width", value1));
     ASSERT_EQ("100px", value1);
 
     String value2;
     ASSERT_TRUE(DictionaryHelper::get(jsKeyframes[1], "width", value2));
     ASSERT_EQ("0px", value2);
 
-    KeyframeEffect* animation = createAnimation(element.get(), jsKeyframes, 0, exceptionState);
+    KeyframeEffect* animation = createAnimation(element.get(), jsKeyframes, 0);
 
     Element* target = animation->target();
     EXPECT_EQ(*element.get(), *target);
 
     const KeyframeVector keyframes = toKeyframeEffectModelBase(animation->model())->getFrames();
 
     EXPECT_EQ(0, keyframes[0]->offset());
     EXPECT_EQ(1, keyframes[1]->offset());
 
     const CSSValue& keyframe1Width = toStringKeyframe(keyframes[0].get())->cssPropertyValue(CSSPropertyWidth);
     const CSSValue& keyframe2Width = toStringKeyframe(keyframes[1].get())->cssPropertyValue(CSSPropertyWidth);
 
     EXPECT_EQ("100px", keyframe1Width.cssText());
     EXPECT_EQ("0px", keyframe2Width.cssText());
 
     EXPECT_EQ(*(CubicBezierTimingFunction::preset(CubicBezierTimingFunction::EaseType::EASE_IN_OUT)), keyframes[0]->easing());
     EXPECT_EQ(*(CubicBezierTimingFunction::create(1, 1, 0.3, 0.3).get()), keyframes[1]->easing());
 }
 
 TEST_F(AnimationKeyframeEffectV8Test, CanSetDuration)
 {
     Vector<Dictionary, 0> jsKeyframes;
     double duration = 2000;
 
-    KeyframeEffect* animation = createAnimation(element.get(), jsKeyframes, duration, exceptionState);
+    KeyframeEffect* animation = createAnimation(element.get(), jsKeyframes, duration);
 
     EXPECT_EQ(duration / 1000, animation->specifiedTiming().iterationDuration);
 }
 
 TEST_F(AnimationKeyframeEffectV8Test, CanOmitSpecifiedDuration)
 {
     Vector<Dictionary, 0> jsKeyframes;
-    KeyframeEffect* animation = createAnimation(element.get(), jsKeyframes, exceptionState);
+    KeyframeEffect* animation = createAnimation(element.get(), jsKeyframes);
     EXPECT_TRUE(std::isnan(animation->specifiedTiming().iterationDuration));
 }
 
 TEST_F(AnimationKeyframeEffectV8Test, SpecifiedGetters)
 {
     V8TestingScope scope;
     Vector<Dictionary, 0> jsKeyframes;
 
     v8::Local<v8::Object> timingInput = v8::Object::New(scope.isolate());
     setV8ObjectPropertyAsNumber(scope.isolate(), timingInput, "delay", 2);
     setV8ObjectPropertyAsNumber(scope.isolate(), timingInput, "endDelay", 0.5);
     setV8ObjectPropertyAsString(scope.isolate(), timingInput, "fill", "backwards");
     setV8ObjectPropertyAsNumber(scope.isolate(), timingInput, "iterationStart", 2);
     setV8ObjectPropertyAsNumber(scope.isolate(), timingInput, "iterations", 10);
     setV8ObjectPropertyAsString(scope.isolate(), timingInput, "direction", "reverse");
     setV8ObjectPropertyAsString(scope.isolate(), timingInput, "easing", "step-start");
     KeyframeEffectOptions timingInputDictionary;
+    TrackExceptionState exceptionState;
     V8KeyframeEffectOptions::toImpl(scope.isolate(), timingInput, timingInputDictionary, exceptionState);
+    EXPECT_FALSE(exceptionState.hadException());
 
-    KeyframeEffect* animation = createAnimation(element.get(), jsKeyframes, timingInputDictionary, exceptionState);
+    KeyframeEffect* animation = createAnimation(element.get(), jsKeyframes, timingInputDictionary);
 
     AnimationEffectTiming* specified = animation->timing();
     EXPECT_EQ(2, specified->delay());
     EXPECT_EQ(0.5, specified->endDelay());
     EXPECT_EQ("backwards", specified->fill());
     EXPECT_EQ(2, specified->iterationStart());
     EXPECT_EQ(10, specified->iterations());
     EXPECT_EQ("reverse", specified->direction());
     EXPECT_EQ("step-start", specified->easing());
 }
 
 TEST_F(AnimationKeyframeEffectV8Test, SpecifiedDurationGetter)
 {
     V8TestingScope scope;
     Vector<Dictionary, 0> jsKeyframes;
 
     v8::Local<v8::Object> timingInputWithDuration = v8::Object::New(scope.isolate());
     setV8ObjectPropertyAsNumber(scope.isolate(), timingInputWithDuration, "duration", 2.5);
     KeyframeEffectOptions timingInputDictionaryWithDuration;
+    TrackExceptionState exceptionState;
     V8KeyframeEffectOptions::toImpl(scope.isolate(), timingInputWithDuration, timingInputDictionaryWithDuration, exceptionState);
+    EXPECT_FALSE(exceptionState.hadException());
 
-    KeyframeEffect* animationWithDuration = createAnimation(element.get(), jsKeyframes, timingInputDictionaryWithDuration, exceptionState);
+    KeyframeEffect* animationWithDuration = createAnimation(element.get(), jsKeyframes, timingInputDictionaryWithDuration);
 
     AnimationEffectTiming* specifiedWithDuration = animationWithDuration->timing();
     UnrestrictedDoubleOrString duration;
     specifiedWithDuration->duration(duration);
     EXPECT_TRUE(duration.isUnrestrictedDouble());
     EXPECT_EQ(2.5, duration.getAsUnrestrictedDouble());
     EXPECT_FALSE(duration.isString());
 
 
     v8::Local<v8::Object> timingInputNoDuration = v8::Object::New(scope.isolate());
     KeyframeEffectOptions timingInputDictionaryNoDuration;
     V8KeyframeEffectOptions::toImpl(scope.isolate(), timingInputNoDuration, timingInputDictionaryNoDuration, exceptionState);
+    EXPECT_FALSE(exceptionState.hadException());
 
-    KeyframeEffect* animationNoDuration = createAnimation(element.get(), jsKeyframes, timingInputDictionaryNoDuration, exceptionState);
+    KeyframeEffect* animationNoDuration = createAnimation(element.get(), jsKeyframes, timingInputDictionaryNoDuration);
 
     AnimationEffectTiming* specifiedNoDuration = animationNoDuration->timing();
     UnrestrictedDoubleOrString duration2;
     specifiedNoDuration->duration(duration2);
     EXPECT_FALSE(duration2.isUnrestrictedDouble());
     EXPECT_TRUE(duration2.isString());
     EXPECT_EQ("auto", duration2.getAsString());
 }
 
 TEST_F(AnimationKeyframeEffectV8Test, SpecifiedSetters)
 {
     V8TestingScope scope;
     Vector<Dictionary, 0> jsKeyframes;
     v8::Local<v8::Object> timingInput = v8::Object::New(scope.isolate());
     KeyframeEffectOptions timingInputDictionary;
+    TrackExceptionState exceptionState;
     V8KeyframeEffectOptions::toImpl(scope.isolate(), timingInput, timingInputDictionary, exceptionState);
-    KeyframeEffect* animation = createAnimation(element.get(), jsKeyframes, timingInputDictionary, exceptionState);
+    EXPECT_FALSE(exceptionState.hadException());
+    KeyframeEffect* animation = createAnimation(element.get(), jsKeyframes, timingInputDictionary);
 
     AnimationEffectTiming* specified = animation->timing();
 
     EXPECT_EQ(0, specified->delay());
     specified->setDelay(2);
     EXPECT_EQ(2, specified->delay());
 
     EXPECT_EQ(0, specified->endDelay());
     specified->setEndDelay(0.5);
     EXPECT_EQ(0.5, specified->endDelay());
@@ skipping 25 matching lines @@
     ASSERT_FALSE(exceptionState.hadException());
     EXPECT_EQ("step-start", specified->easing());
 }
 
 TEST_F(AnimationKeyframeEffectV8Test, SetSpecifiedDuration)
 {
     V8TestingScope scope;
     Vector<Dictionary, 0> jsKeyframes;
     v8::Local<v8::Object> timingInput = v8::Object::New(scope.isolate());
     KeyframeEffectOptions timingInputDictionary;
+    TrackExceptionState exceptionState;
     V8KeyframeEffectOptions::toImpl(scope.isolate(), timingInput, timingInputDictionary, exceptionState);
-    KeyframeEffect* animation = createAnimation(element.get(), jsKeyframes, timingInputDictionary, exceptionState);
+    EXPECT_FALSE(exceptionState.hadException());
+    KeyframeEffect* animation = createAnimation(element.get(), jsKeyframes, timingInputDictionary);
 
     AnimationEffectTiming* specified = animation->timing();
 
     UnrestrictedDoubleOrString duration;
     specified->duration(duration);
     EXPECT_FALSE(duration.isUnrestrictedDouble());
     EXPECT_TRUE(duration.isString());
     EXPECT_EQ("auto", duration.getAsString());
 
     UnrestrictedDoubleOrString inDuration;
@@ skipping 111 matching lines @@
     Timing timing;
     timing.iterationDuration = 5;
     KeyframeEffect* animation = KeyframeEffect::create(element.get(), nullptr, timing);
     EXPECT_EQ(element.get(), animation->target());
     document().timeline().play(animation);
     pageHolder.reset();
     element.clear();
 }
 
 } // namespace blink