Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issue 2272033002: Refactor SMIL animation value updates (Closed)

Created:
4 years, 4 months ago by fs
Modified:
4 years, 3 months ago
Reviewers:
pdr., Stephen Chennney
CC:
fs, darktears, blink-reviews, blink-reviews-animation_chromium.org, chromium-reviews, krit, Eric Willigers, f(malita), gyuyoung2, kouhei+svg_chromium.org, pdr+svgwatchlist_chromium.org, rjwright, rwlbuis, Stephen Chennney, shans
Base URL:
https://chromium.googlesource.com/chromium/src.git@smil-css-prop-update
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Refactor SMIL animation value updates Push updating of the animation value into SVGElement. This resembles the Web Animations code-path to some degree and maybe we can make them even more similar eventually. This is the first CL in a series that will remove knowledge of <use>/shadow trees from the SMIL animation code. BUG=640676 Committed: https://crrev.com/451966ed6788fba2dd2526db15f859c7013b6c13 Cr-Commit-Position: refs/heads/master@{#414366}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -55 lines) Patch
M third_party/WebKit/Source/core/svg/SVGAnimateElement.h View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/svg/SVGAnimateElement.cpp View 2 chunks +6 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGAnimatedTypeAnimator.h View 4 chunks +4 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGAnimatedTypeAnimator.cpp View 1 chunk +12 lines, -35 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGAnimationElement.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/svg/SVGElement.h View 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGElement.cpp View 2 chunks +24 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 13 (8 generated)
fs
Maybe I should've left the DCHECK_EQ(shouldApply, ApplyCSSAnimation) change in SVGAnimateElement.cpp out of this CL, but...
4 years, 4 months ago (2016-08-24 17:46:11 UTC) #5
pdr.
On 2016/08/24 at 17:46:11, fs wrote: > Maybe I should've left the DCHECK_EQ(shouldApply, ApplyCSSAnimation) change ...
4 years, 4 months ago (2016-08-24 19:59:13 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2272033002/1
4 years, 3 months ago (2016-08-25 08:21:54 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-08-25 09:06:09 UTC) #11
commit-bot: I haz the power
4 years, 3 months ago (2016-08-25 09:08:37 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/451966ed6788fba2dd2526db15f859c7013b6c13
Cr-Commit-Position: refs/heads/master@{#414366}

Powered by Google App Engine
This is Rietveld 408576698