Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Issue 2270363004: Simplify SMIL animation CSS property updates (Closed)

Created:
4 years, 4 months ago by fs
Modified:
4 years, 2 months ago
Reviewers:
pdr., Eric Willigers
CC:
fs, darktears, blink-reviews, blink-reviews-animation_chromium.org, chromium-reviews, krit, Eric Willigers, f(malita), gyuyoung2, kouhei+svg_chromium.org, pdr+svgwatchlist_chromium.org, rjwright, rwlbuis, Stephen Chennney, shans
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Simplify SMIL animation CSS property updates After https://codereview.chromium.org/2251073002 we should no longer need to walk any <use> instances "manually", since setNeedsStyleRecalc does that already. This should also avoid the potential double-work because of this. TEST=svg/W3C-SVG-1.1/animate-elem-30-t.svg TEST=svg/W3C-SVG-1.1/animate-elem-40-t.svg BUG=166438, 355359, 484552, 637310 Committed: https://crrev.com/464a055cb87833a40d439b13ae4b8e560322a576 Cr-Commit-Position: refs/heads/master@{#414358}

Patch Set 1 #

Patch Set 2 : Silly stuff happen to good people (too) #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -34 lines) Patch
M third_party/WebKit/Source/core/svg/SVGAnimateElement.cpp View 1 3 chunks +6 lines, -34 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 13 (7 generated)
fs
4 years, 4 months ago (2016-08-24 16:40:54 UTC) #4
pdr.
On 2016/08/24 at 16:40:54, fs wrote: > LGTM! Please give ericwilligers a chance to review ...
4 years, 4 months ago (2016-08-24 20:02:07 UTC) #7
Eric Willigers
lgtm
4 years, 3 months ago (2016-08-25 01:46:32 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2270363004/20001
4 years, 3 months ago (2016-08-25 07:41:23 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-08-25 08:17:49 UTC) #11
commit-bot: I haz the power
4 years, 3 months ago (2016-08-25 08:21:15 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/464a055cb87833a40d439b13ae4b8e560322a576
Cr-Commit-Position: refs/heads/master@{#414358}

Powered by Google App Engine
This is Rietveld 408576698