Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(538)

Unified Diff: third_party/WebKit/Source/core/svg/SVGAnimatedTypeAnimator.h

Issue 2272033002: Refactor SMIL animation value updates (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@smil-css-prop-update
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/svg/SVGAnimatedTypeAnimator.h
diff --git a/third_party/WebKit/Source/core/svg/SVGAnimatedTypeAnimator.h b/third_party/WebKit/Source/core/svg/SVGAnimatedTypeAnimator.h
index 5f2cbca47ba5f4e63809cbe9d264fb1d388f8c7e..c8ee8a6a02edebcb08759d80ef7963c74add717f 100644
--- a/third_party/WebKit/Source/core/svg/SVGAnimatedTypeAnimator.h
+++ b/third_party/WebKit/Source/core/svg/SVGAnimatedTypeAnimator.h
@@ -23,8 +23,6 @@
#include "core/svg/properties/SVGPropertyInfo.h"
#include "platform/heap/Handle.h"
-#include "wtf/RefPtr.h"
-#include "wtf/Vector.h"
#include "wtf/text/WTFString.h"
namespace blink {
@@ -34,9 +32,6 @@ class SVGPropertyBase;
class SVGElement;
class SVGAnimationElement;
-// The size of SVGElementInstances is 1 unless there is a <use> instance of the element.
-using SVGElementInstances = HeapVector<Member<SVGElement>, 1u>;
-
class SVGAnimatedTypeAnimator final {
DISALLOW_NEW();
public:
@@ -47,9 +42,9 @@ public:
SVGPropertyBase* constructFromString(const String&);
- SVGPropertyBase* startAnimValAnimation(const SVGElementInstances&);
- void stopAnimValAnimation(const SVGElementInstances&);
- SVGPropertyBase* resetAnimValToBaseVal(const SVGElementInstances&);
+ SVGPropertyBase* startAnimValAnimation();
+ void stopAnimValAnimation();
+ SVGPropertyBase* resetAnimValToBaseVal();
void calculateAnimatedValue(float percentage, unsigned repeatCount, SVGPropertyBase*, SVGPropertyBase*, SVGPropertyBase*, SVGPropertyBase*);
float calculateDistance(const String& fromString, const String& toString);
@@ -68,7 +63,7 @@ public:
private:
friend class ParsePropertyFromString;
SVGPropertyBase* createPropertyForAnimation(const String&);
- SVGPropertyBase* resetAnimation(const SVGElementInstances&);
+ SVGPropertyBase* resetAnimation();
Member<SVGAnimationElement> m_animationElement;
Member<SVGElement> m_contextElement;

Powered by Google App Engine
This is Rietveld 408576698