Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(335)

Unified Diff: third_party/WebKit/Source/core/svg/SVGAnimateElement.cpp

Issue 2272033002: Refactor SMIL animation value updates (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@smil-css-prop-update
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/svg/SVGAnimateElement.cpp
diff --git a/third_party/WebKit/Source/core/svg/SVGAnimateElement.cpp b/third_party/WebKit/Source/core/svg/SVGAnimateElement.cpp
index 31195dc870d7e0b5e4c603bfdd11f95bd3a30823..85f448bb01e9209c2bc4a717f10003b5483fd2da 100644
--- a/third_party/WebKit/Source/core/svg/SVGAnimateElement.cpp
+++ b/third_party/WebKit/Source/core/svg/SVGAnimateElement.cpp
@@ -190,20 +190,18 @@ void SVGAnimateElement::resetAnimatedType()
addReferenceTo(element);
if (!m_animatedProperty)
- m_animatedProperty = m_animator.startAnimValAnimation(animatedElements);
+ m_animatedProperty = m_animator.startAnimValAnimation();
else
- m_animatedProperty = m_animator.resetAnimValToBaseVal(animatedElements);
+ m_animatedProperty = m_animator.resetAnimValToBaseVal();
return;
}
+ DCHECK_EQ(shouldApply, ApplyCSSAnimation);
// CSS properties animation code-path.
String baseValue;
-
- if (shouldApply == ApplyCSSAnimation) {
- ASSERT(SVGAnimationElement::isTargetAttributeCSSProperty(targetElement, attributeName));
- computeCSSPropertyValue(targetElement, cssPropertyID(attributeName.localName()), baseValue);
- }
+ DCHECK(isTargetAttributeCSSProperty(targetElement, attributeName));
+ computeCSSPropertyValue(targetElement, cssPropertyID(attributeName.localName()), baseValue);
m_animatedProperty = m_animator.constructFromString(baseValue);
}
@@ -282,8 +280,7 @@ void SVGAnimateElement::clearAnimatedType()
// SVG DOM animVal animation code-path.
if (m_animatedProperty) {
- SVGElementInstances animatedElements = findElementInstances(targetElement);
- m_animator.stopAnimValAnimation(animatedElements);
+ m_animator.stopAnimValAnimation();
notifyTargetAndInstancesAboutAnimValChange(targetElement, attributeName());
}
« no previous file with comments | « third_party/WebKit/Source/core/svg/SVGAnimateElement.h ('k') | third_party/WebKit/Source/core/svg/SVGAnimatedTypeAnimator.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698