Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1004)

Unified Diff: third_party/WebKit/Source/modules/payments/PaymentCurrencyAmount.idl

Issue 2271113002: Accept any string for currency code in PaymentRequest. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixed 640847 Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/payments/PaymentCurrencyAmount.idl
diff --git a/third_party/WebKit/Source/modules/payments/PaymentCurrencyAmount.idl b/third_party/WebKit/Source/modules/payments/PaymentCurrencyAmount.idl
index b022c715f15825c5a6376dc4f6c63eaa03c084af..fcc67d44c6a66823dd008ad856c7237a80bb58fc 100644
--- a/third_party/WebKit/Source/modules/payments/PaymentCurrencyAmount.idl
+++ b/third_party/WebKit/Source/modules/payments/PaymentCurrencyAmount.idl
@@ -7,6 +7,6 @@
[
RuntimeEnabled=PaymentRequest
] dictionary PaymentCurrencyAmount {
- required DOMString currency;
+ [TreatNullAs=NullString] required DOMString currency;
please use gerrit instead 2016/08/25 16:47:38 Let's not allow nulls. At least an empty string sh
haraken 2016/08/26 01:20:05 Right, [TreatNullAs] must be accompanied with Empt
pals 2016/08/26 07:20:26 ['Null currency code should throw', null, function
please use gerrit instead 2016/08/26 17:01:37 OK
required DOMString value;
};

Powered by Google App Engine
This is Rietveld 408576698