third_party/WebKit/Source/modules/payments/PaymentCurrencyAmount.idl - Issue 2271113002: Accept any string for currency code in PaymentRequest.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/Source/modules/payments/PaymentCurrencyAmount.idl

Issue 2271113002: Accept any string for currency code in PaymentRequest. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixed 640847 Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/android/junit/src/org/chromium/chrome/browser/payments/CurrencyStringFormatterTest.java ('K') | « third_party/WebKit/LayoutTests/payments/payment-request-interface.html ('k') | third_party/WebKit/Source/modules/payments/PaymentRequestDetailsTest.cpp » ('j') | third_party/WebKit/Source/modules/payments/PaymentsValidators.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright 2016 The Chromium Authors. All rights reserved.	1 // Copyright 2016 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 // https://w3c.github.io/browser-payment-api/#paymentcurrencyamount	5 // https://w3c.github.io/browser-payment-api/#paymentcurrencyamount

6	6

7 [	7 [

8 RuntimeEnabled=PaymentRequest	8 RuntimeEnabled=PaymentRequest

9 ] dictionary PaymentCurrencyAmount {	9 ] dictionary PaymentCurrencyAmount {

10 required DOMString currency;	10 [TreatNullAs=NullString] required DOMString currency;
	please use gerrit instead 2016/08/25 16:47:38 Let's not allow nulls. At least an empty string sh Let's not allow nulls. At least an empty string should be specified. haraken 2016/08/26 01:20:05 Right, [TreatNullAs] must be accompanied with Empt Show quoted text On 2016/08/25 16:47:38, rouslan wrote: > Let's not allow nulls. At least an empty string should be specified. Right, [TreatNullAs] must be accompanied with EmptyString per the spec: https://www.w3.org/TR/WebIDL/#TreatNullAs pals 2016/08/26 07:20:26 ['Null currency code should throw', null, function Show quoted text On 2016/08/26 01:20:05, haraken wrote: > On 2016/08/25 16:47:38, rouslan wrote: > > Let's not allow nulls. At least an empty string should be specified. > > Right, [TreatNullAs] must be accompanied with EmptyString per the spec: > > https://www.w3.org/TR/WebIDL/#TreatNullAs ['Null currency code should throw', null, function() { new PaymentRequest([{'supportedMethods': ['foo']}], buildDetails(detailNames[i], {'currency': null})) }], For this test case, the value of \|item.amount().currency()\| in [1] is coming as "null", so its not throwing any exception. [1] https://cs.chromium.org/chromium/src/third_party/WebKit/Source/modules/paymen... please use gerrit instead 2016/08/26 17:01:37 OK OK
11 required DOMString value;	11 required DOMString value;

12 };	12 };

OLD	NEW