chrome/android/junit/src/org/chromium/chrome/browser/payments/CurrencyStringFormatterTest.java - Issue 2271113002: Accept any string for currency code in PaymentRequest.

Unified Diff: chrome/android/junit/src/org/chromium/chrome/browser/payments/CurrencyStringFormatterTest.java

Issue 2271113002: Accept any string for currency code in PaymentRequest. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixed 640847 Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/android/java/src/org/chromium/chrome/browser/payments/ui/PaymentRequestSection.java ('K') | « chrome/android/java/src/org/chromium/chrome/browser/payments/ui/PaymentRequestSection.java ('k') | third_party/WebKit/LayoutTests/payments/payment-request-interface.html » ('j') | third_party/WebKit/Source/modules/payments/PaymentCurrencyAmount.idl » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/junit/src/org/chromium/chrome/browser/payments/CurrencyStringFormatterTest.java

diff --git a/chrome/android/junit/src/org/chromium/chrome/browser/payments/CurrencyStringFormatterTest.java b/chrome/android/junit/src/org/chromium/chrome/browser/payments/CurrencyStringFormatterTest.java

index f86a8aaa33f84a15d99121b2f2d644ebc8a0634e..4d676060b6ce98684662d68c795b73ba2cee1c8b 100644

--- a/chrome/android/junit/src/org/chromium/chrome/browser/payments/CurrencyStringFormatterTest.java

+++ b/chrome/android/junit/src/org/chromium/chrome/browser/payments/CurrencyStringFormatterTest.java

@@ -69,14 +69,6 @@ public class CurrencyStringFormatterTest {

"$123,456,789,012,345,678,901,234,567,890.123456789012345678901234567890",

ExpectedValidity.VALID_AMOUNT},

- // Invalid amount currency codes.

- {"55.00", "", "en-US", null, ExpectedValidity.INVALID_AMOUNT_CURRENCY_CODE},

- {"55.00", "usd", "en-US", null, ExpectedValidity.INVALID_AMOUNT_CURRENCY_CODE},

- {"55.00", "US8", "en-US", null, ExpectedValidity.INVALID_AMOUNT_CURRENCY_CODE},

- {"55.00", "US", "en-US", null, ExpectedValidity.INVALID_AMOUNT_CURRENCY_CODE},

- {"55.00", "USDR", "en-US", null, ExpectedValidity.INVALID_AMOUNT_CURRENCY_CODE},

- {"55.00", "USDr", "en-US", null, ExpectedValidity.INVALID_AMOUNT_CURRENCY_CODE},

please use gerrit instead 2016/08/25 16:47:38 Once you move currency truncation into CurrenycStr

pals 2016/08/26 07:20:26 If it is ok, I'll do the application related chang

please use gerrit instead 2016/08/26 17:01:37 OK

// Invalid amount values.

{"", "USD", "en-US", null, ExpectedValidity.INVALID_AMOUNT_VALUE},

{"-", "USD", "en-US", null, ExpectedValidity.INVALID_AMOUNT_VALUE},