third_party/WebKit/Source/modules/payments/PaymentsValidators.h - Issue 2271113002: Accept any string for currency code in PaymentRequest.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/payments/PaymentsValidators.h

Issue 2271113002: Accept any string for currency code in PaymentRequest. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixed 640847 Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/modules/payments/PaymentCurrencyAmount.idl ('K') | « third_party/WebKit/Source/modules/payments/PaymentRequestDetailsTest.cpp ('k') | third_party/WebKit/Source/modules/payments/PaymentsValidators.cpp » ('j') | third_party/WebKit/Source/modules/payments/PaymentsValidators.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/payments/PaymentsValidators.h

diff --git a/third_party/WebKit/Source/modules/payments/PaymentsValidators.h b/third_party/WebKit/Source/modules/payments/PaymentsValidators.h

index 2ef1e37572f9ba39c54976cbc546dd91ebffd8d6..a01693625b923200735238b0873be48aacf1992b 100644

--- a/third_party/WebKit/Source/modules/payments/PaymentsValidators.h

+++ b/third_party/WebKit/Source/modules/payments/PaymentsValidators.h

@@ -16,7 +16,8 @@ class MODULES_EXPORT PaymentsValidators final {

STATIC_ONLY(PaymentsValidators);

public:

- // Returns true if |code| is a valid ISO 4217 currency code.

+ // The most common identifiers are three-letter alphabetic codes as defined by [ISO4217] (for example, "USD" for US Dollars)

+ // however any string is considered valid. Returns false if currency |code| is too long ( greater than 2048).

please use gerrit instead 2016/08/25 16:47:38 No space after (

pals 2016/08/26 07:20:26 Done.

static bool isValidCurrencyCodeFormat(const String& code, String* optionalErrorMessage);

// Returns true if |amount| is a valid currency code as defined in ISO 20022 CurrencyAnd30Amount.