Subzero: Add the MIPS=1 makefile option for alternate testing mode.

Subzero: Add the MIPS=1 makefile option for alternate testing mode.

There are two problems to address:

1. Google developers lack some tooling to test MIPS changes.

2. MIPS developers lack some tooling/packages to allow full "make presubmit" testing.

Until all this gets sorted out, we add the "make -f Makefile.standalone MIPS=1" option to control some of the testing targets:

check-lit: No changes, as all these lit tests should be runnable in both environments.

check-xtest: MIPS=1 runs just the mips32 tests, plus the x8664 native tests as a sanity-check.  Non-MIPS runs everything except the mips32 tests.

check-spec: MIPS=1 completely disables spec2k testing.

presubmit: MIPS=1 greatly reduces the number of tests (especially since so many are spec variants).


With this change, mips32 CLs should pass "make -f Makefile.standalone MIPS=1 presubmit" before upload, and other CLs should pass "make -f Makefile.standalone presubmit".

BUG= none
R=kschimpf@google.com, obucinac@gmail.com

Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=cc8bc16fffd84c5eb7bd35078398034f53c587a3

[Jim Stichnoth, 2016-08-25 18:13:31]

Description was changed from

==========
Subzero: Add the MIPS=1 makefile option for alternate testing mode.

BUG= none
==========

to

==========
Subzero: Add the MIPS=1 makefile option for alternate testing mode.

There are two problems to address:

1. Google developers lack some tooling to test MIPS changes.

2. MIPS developers lack some tooling/packages to allow full "make presubmit"
testing.

Until all this gets sorted out, we add the "make -f Makefile.standalone MIPS=1"
option to control some of the testing targets:

check-lit: No changes, as all these lit tests should be runnable in both
environments.

check-xtest: MIPS=1 runs just the mips32 tests, plus the x8664 native tests as a
sanity-check.  Non-MIPS runs everything except the mips32 tests.

check-spec: MIPS=1 completely disables spec2k testing.

presubmit: MIPS=1 greatly reduces the number of tests (especially since so many
are spec variants).


With this change, mips32 CLs should pass "make -f Makefile.standalone MIPS=1
presubmit" before upload, and other CLs should pass "make -f Makefile.standalone
presubmit".

BUG= none
==========

[Jim Stichnoth, 2016-08-25 18:27:19]

stichnot@chromium.org changed reviewers:
+ eholk@chromium.org, jaydeep.patil@imgtec.com, jpp@chromium.org,
kschimpf@google.com, mohit.bhakkad@imgtec.com, sagar.thakur@imgtec.com

[Jim Stichnoth, 2016-08-25 18:30:13]

[not sure how to get srdjan.obucina as a reviewer...]

MIPS folks: Please help me test that this works on your end, e.g.:

git checkout master
git cl patch -b my_test 2271053006
make -f Makefile.standalone presubmit MIPS=1

[Karl, 2016-08-31 21:13:41]

lgtm

[obucinac, 2016-09-01 16:31:19]

obucinac@gmail.com changed reviewers:
+ obucinac@gmail.com

[obucinac, 2016-09-01 16:31:20]

https://codereview.chromium.org/2271053006/diff/40001/Makefile.standalone
File Makefile.standalone (right):

https://codereview.chromium.org/2271053006/diff/40001/Makefile.standalone#new...
Makefile.standalone:557: else
It appears

make -f Makefile.standalone check-xtest

runs all tests (does not exclude MIPS tests), command line is

./pydir/crosstest_generator.py -v --lit \
          --toolchain-root
/home/obucina/pnacl/nacl/native_client/toolchain/linux_x86 \
           \
           \
          -i x8632,native,sse2 \
          -i x8632,native,sse4.1,test_vector_ops \
          -i x8632,sandbox,sse4.1,Om1 \
          -i x8632,nonsfi,sse2,O2 \
          -i x8664,native,sse2 \
          -i x8664,native,sse4.1,test_vector_ops \
          -i x8664,sandbox,sse4.1,Om1 \
          -i arm32 \
          -i mips32 \
          -i mips32,native \
          -e arm32,sandbox,hwdiv-arm

On the other side

make -f Makefile.standalone check-xtest MIPS=1

runs as expected. Command line is

./pydir/crosstest_generator.py -v --lit \
          --toolchain-root
/home/obucina/pnacl/nacl/native_client/toolchain/linux_x86 \
           \
           \
          -i x8664,native,sse2 \
          -i mips32,xxx

[obucinac, 2016-09-01 16:47:13]

On 2016/09/01 16:31:20, obucinac wrote:
> https://codereview.chromium.org/2271053006/diff/40001/Makefile.standalone
> File Makefile.standalone (right):
> 
>
https://codereview.chromium.org/2271053006/diff/40001/Makefile.standalone#new...
> Makefile.standalone:557: else
> It appears
> 
> make -f Makefile.standalone check-xtest
> 
> runs all tests (does not exclude MIPS tests), command line is
> 
> ./pydir/crosstest_generator.py -v --lit \
>           --toolchain-root
> /home/obucina/pnacl/nacl/native_client/toolchain/linux_x86 \
>            \
>            \
>           -i x8632,native,sse2 \
>           -i x8632,native,sse4.1,test_vector_ops \
>           -i x8632,sandbox,sse4.1,Om1 \
>           -i x8632,nonsfi,sse2,O2 \
>           -i x8664,native,sse2 \
>           -i x8664,native,sse4.1,test_vector_ops \
>           -i x8664,sandbox,sse4.1,Om1 \
>           -i arm32 \
>           -i mips32 \
>           -i mips32,native \
>           -e arm32,sandbox,hwdiv-arm
> 
> On the other side
> 
> make -f Makefile.standalone check-xtest MIPS=1
> 
> runs as expected. Command line is
> 
> ./pydir/crosstest_generator.py -v --lit \
>           --toolchain-root
> /home/obucina/pnacl/nacl/native_client/toolchain/linux_x86 \
>            \
>            \
>           -i x8664,native,sse2 \
>           -i mips32,xxx

I tested this combined with patch https://codereview.chromium.org/2085303002/

[obucinac, 2016-09-02 13:06:46]

lgtm

I will resolve the problem I saw in my patch.

[Jim Stichnoth, 2016-09-02 13:28:44]

On 2016/09/01 16:31:20, obucinac wrote:
> https://codereview.chromium.org/2271053006/diff/40001/Makefile.standalone
> File Makefile.standalone (right):
> 
>
https://codereview.chromium.org/2271053006/diff/40001/Makefile.standalone#new...
> Makefile.standalone:557: else
> It appears
> 
> make -f Makefile.standalone check-xtest
> 
> runs all tests (does not exclude MIPS tests), command line is
> 
> ./pydir/crosstest_generator.py -v --lit \
>           --toolchain-root
> /home/obucina/pnacl/nacl/native_client/toolchain/linux_x86 \
>            \
>            \
>           -i x8632,native,sse2 \
>           -i x8632,native,sse4.1,test_vector_ops \
>           -i x8632,sandbox,sse4.1,Om1 \
>           -i x8632,nonsfi,sse2,O2 \
>           -i x8664,native,sse2 \
>           -i x8664,native,sse4.1,test_vector_ops \
>           -i x8664,sandbox,sse4.1,Om1 \
>           -i arm32 \
>           -i mips32 \
>           -i mips32,native \
>           -e arm32,sandbox,hwdiv-arm
> 
> On the other side
> 
> make -f Makefile.standalone check-xtest MIPS=1
> 
> runs as expected. Command line is
> 
> ./pydir/crosstest_generator.py -v --lit \
>           --toolchain-root
> /home/obucina/pnacl/nacl/native_client/toolchain/linux_x86 \
>            \
>            \
>           -i x8664,native,sse2 \
>           -i mips32,xxx

Right - in the MIPS cross tests CL, the "-i mips32,..." line would be added to
the "ifdef MIPS" section and not the (original) "else" section.

[Jim Stichnoth, 2016-09-02 13:29:50]

Description was changed from

==========
Subzero: Add the MIPS=1 makefile option for alternate testing mode.

There are two problems to address:

1. Google developers lack some tooling to test MIPS changes.

2. MIPS developers lack some tooling/packages to allow full "make presubmit"
testing.

Until all this gets sorted out, we add the "make -f Makefile.standalone MIPS=1"
option to control some of the testing targets:

check-lit: No changes, as all these lit tests should be runnable in both
environments.

check-xtest: MIPS=1 runs just the mips32 tests, plus the x8664 native tests as a
sanity-check.  Non-MIPS runs everything except the mips32 tests.

check-spec: MIPS=1 completely disables spec2k testing.

presubmit: MIPS=1 greatly reduces the number of tests (especially since so many
are spec variants).


With this change, mips32 CLs should pass "make -f Makefile.standalone MIPS=1
presubmit" before upload, and other CLs should pass "make -f Makefile.standalone
presubmit".

BUG= none
==========

to

==========
Subzero: Add the MIPS=1 makefile option for alternate testing mode.

There are two problems to address:

1. Google developers lack some tooling to test MIPS changes.

2. MIPS developers lack some tooling/packages to allow full "make presubmit"
testing.

Until all this gets sorted out, we add the "make -f Makefile.standalone MIPS=1"
option to control some of the testing targets:

check-lit: No changes, as all these lit tests should be runnable in both
environments.

check-xtest: MIPS=1 runs just the mips32 tests, plus the x8664 native tests as a
sanity-check.  Non-MIPS runs everything except the mips32 tests.

check-spec: MIPS=1 completely disables spec2k testing.

presubmit: MIPS=1 greatly reduces the number of tests (especially since so many
are spec variants).


With this change, mips32 CLs should pass "make -f Makefile.standalone MIPS=1
presubmit" before upload, and other CLs should pass "make -f Makefile.standalone
presubmit".

BUG= none
R=kschimpf@google.com, obucinac@gmail.com

Committed:
https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a...
==========

[Jim Stichnoth, 2016-09-02 13:29:52]

Committed patchset #3 (id:40001) manually as
cc8bc16fffd84c5eb7bd35078398034f53c587a3 (presubmit successful).