Subzero: Add the MIPS=1 makefile option for alternate testing mode.

Makefile.standalone

 # The following variables will likely need to be modified, depending on where
 # and how you built LLVM & Clang. They can be overridden in a command-line
 # invocation of make, like:
 #
 #   make LLVM_SRC_PATH=<path> LIBCXX_INSTALL_PATH=<path> CLANG_PATH=<path> \
 #        PNACL_BIN_PATH=<path> ...
 #
 
 # LLVM_SRC_PATH is the path to the root of the checked out source code. This
 # directory should contain the configure script, the include/ and lib/
@@ skipping 523 matching lines @@
 
 check-lit: $(OBJDIR)/pnacl-sz make_symlink runtime
         PNACL_BIN_PATH=$(PNACL_BIN_PATH) \
         $(LLVM_SRC_PATH)/utils/lit/lit.py -sv $(CHECK_LIT_TESTS) \
             $(FORCEASM_LIT_TEST_EXCLUDES) $(FORCEASM_LIT_PARAM)
 
 ifdef MINIMAL
 check-xtest check-xtest-lite: $(OBJDIR)/pnacl-sz make_symlink runtime
         @echo "Crosstests disabled, minimal build"
 else
+ifdef MIPS
+check-xtest check-xtest-lite: $(OBJDIR)/pnacl-sz make_symlink runtime \
+  crosstest/test_arith_ll.ll
+       # Do all x8664/native/sse2 tests as a smoke test.
+       # Add in mips32 tests as they come online.
+        ./pydir/crosstest_generator.py -v --lit \
+          --toolchain-root $(TOOLCHAIN_ROOT) \
+          $(FORCEASM_FLAG) \
+          $(FORCEASM_XTEST_EXCLUDES) \
+          -i x8664,native,sse2 \
+          -i mips32,xxx
+        PNACL_BIN_PATH=$(PNACL_BIN_PATH) \
+        $(LLVM_SRC_PATH)/utils/lit/lit.py -sv $(CHECK_XTEST_TESTS)
+else

[obucinac, 2016/09/01 16:31:20]

It appears

make -f Makefile.standalone check-xtest

runs all tests (does not exclude MIPS tests), command line is

./pydir/crosstest_generator.py -v --lit \
          --toolchain-root
/home/obucina/pnacl/nacl/native_client/toolchain/linux_x86 \
           \
           \
          -i x8632,native,sse2 \
          -i x8632,native,sse4.1,test_vector_ops \
          -i x8632,sandbox,sse4.1,Om1 \
          -i x8632,nonsfi,sse2,O2 \
          -i x8664,native,sse2 \
          -i x8664,native,sse4.1,test_vector_ops \
          -i x8664,sandbox,sse4.1,Om1 \
          -i arm32 \
          -i mips32 \
          -i mips32,native \
          -e arm32,sandbox,hwdiv-arm

On the other side

make -f Makefile.standalone check-xtest MIPS=1

runs as expected. Command line is

./pydir/crosstest_generator.py -v --lit \
          --toolchain-root
/home/obucina/pnacl/nacl/native_client/toolchain/linux_x86 \
           \
           \
          -i x8664,native,sse2 \
          -i mips32,xxx

 check-xtest: $(OBJDIR)/pnacl-sz make_symlink runtime \
   exists-nonsfi-x8632 exists-nonsfi-arm32 crosstest/test_arith_ll.ll
        # Do all native/sse2 tests, but only test_vector_ops for native/sse4.1.
        # For (slow) sandboxed tests, limit to Om1/sse4.1.
        # run.py (used to run the sandboxed xtests) does not support
        # specifying -cpu cortex-a15 to qemu, hence we disable the
        # hwdiv-arm tests.
         ./pydir/crosstest_generator.py -v --lit \
           --toolchain-root $(TOOLCHAIN_ROOT) \
           $(FORCEASM_FLAG) \
@@ skipping 27 matching lines @@
           -i x8664,sse2,O2,test_global \
           -i x8664,sse2,O2,mem_intrin \
           -i arm32,neon,O2,test_global \
           -i arm32,neon,O2,mem_intrin \
           -e x8664,nonsfi
         PNACL_BIN_PATH=$(PNACL_BIN_PATH) \
         $(LLVM_SRC_PATH)/utils/lit/lit.py -sv $(CHECK_XTEST_TESTS)
 crosstest/test_arith_ll.ll: pydir/gen_test_arith_ll.py
         python $< > $@
 endif
+endif
 
 check-unit: $(OBJDIR)/run_unittests
         $(OBJDIR)/run_unittests
 
 # List the spec2k components in roughly reverse order of runtime, to help with
 # parallel execution speed.
 ALLSPEC := 253.perlbmk 177.mesa 188.ammp 256.bzip2 164.gzip 179.art 183.equake \
            175.vpr 176.gcc 181.mcf 186.crafty 197.parser 254.gap 255.vortex \
            300.twolf 252.eon
 .PHONY: $(ALLSPEC)
@@ skipping 13 matching lines @@
   TARGETFLAG=arm32
   SETUP=SetupGccArmOpt
   SPEC := --filetype=obj
 endif
 SPECFLAGS := -O2
 SPECRUN := --run
 %.spec2k: % $(OBJDIR)/pnacl-sz make_symlink runtime
         ./pydir/szbuild_spec2k.py -v \
           $(SPECFLAGS) --target=$(TARGETFLAG) $(SPEC) $< $(SPECRUN)
 
+ifdef MIPS
+# Don't test spec2k on mips32, at least not yet.
+check-spec:
+else
 check-spec: exists-spec $(ALLSPEC:=.spec2k)
+endif
 
 check: check-lit check-unit check-xtest
 
 NONSFI_LOADER_X8632 = \
   $(NACL_ROOT)/scons-out/opt-linux-x86-32/obj/src/nonsfi/loader/nonsfi_loader
 NONSFI_LOADER_ARM32 = \
   $(NACL_ROOT)/scons-out/opt-linux-arm/obj/src/nonsfi/loader/nonsfi_loader
 SBTC_LIBFILE = $(SB_LLVM_PATH)/lib/libLLVMSupport.a
 SPEC_SAMPLE_PEXE = $(NACL_ROOT)/tests/spec2k/176.gcc/gcc.opt.stripped.pexe
 
@@ skipping 22 matching lines @@
 
 exists-spec:
         @if [ ! -f $(SPEC_SAMPLE_PEXE) ] ; then \
           echo "Missing file $(SPEC_SAMPLE_PEXE)"; \
           echo "Consider running" \
                "'./run_all.sh BuildBenchmarks 0 SetupPnaclX8632Opt'" \
                "in the native_client/tests/spec2k directory."; \
           exit 1 ; \
         fi
 
+ifdef MIPS
+check-presubmit presubmit: exists-sbtc
+# Make sure clang-format gets run.
+        +make -f Makefile.standalone format
+# Verify MINIMAL build, plus proper usage of REQUIRES in lit tests.
+        +make -f Makefile.standalone \
+          MINIMAL=1 check
+# Check that there are no g++ build errors or warnings.
+        +make -f Makefile.standalone \
+          GPLUSPLUS=1 compile_only
+# Run lit tests, cross tests, and unit tests.
+        +make -f Makefile.standalone \
+          check
+# Check a sandboxed translator build.
+        +make -f Makefile.standalone \
+          DEBUG=1 sb
+# Provide validation of user awesomeness!
+        echo Success
+else
 check-presubmit presubmit: exists-nonsfi-x8632 exists-nonsfi-arm32 \
   exists-sbtc exists-spec
 # Make sure clang-format gets run.
         +make -f Makefile.standalone format
 # Verify MINIMAL build, plus proper usage of REQUIRES in lit tests.
         +make -f Makefile.standalone \
           MINIMAL=1 check
 # Check that there are no g++ build errors or warnings.
         +make -f Makefile.standalone \
           GPLUSPLUS=1 compile_only
@@ skipping 29 matching lines @@
           TARGET=arm32 SPECRUN= check-spec
 # Build spec2k under -Om1/arm32.
         +make -f Makefile.standalone \
           TARGET=arm32 SPECFLAGS='-Om1' SPECRUN= check-spec
 # Run a few spec2k tests for arm32 using qemu. Keep the list sorted in
 # roughly reverse order of runtime.
         +make -f Makefile.standalone \
           TARGET=arm32 ALLSPEC='252.eon 254.gap 176.gcc 181.mcf' check-spec
 # Provide validation of user awesomeness!
         echo Success
+endif
 
 presubmit-lite: exists-nonsfi-x8632 exists-nonsfi-arm32 \
   exists-sbtc exists-spec
 # Make sure clang-format gets run.
         +make -f Makefile.standalone format
 # Verify MINIMAL build, plus proper usage of REQUIRES in lit tests.
         +make -f Makefile.standalone \
           MINIMAL=1 check sb-lite
 # Check that there are no g++ build errors or warnings.
         +make -f Makefile.standalone \
@@ skipping 67 matching lines @@
 
 help-check-xtest:
         @cat Makefile.standalone-help/check-xtest.txt
 
 clean:
         rm -rf pnacl-sz *.o $(foreach nexe,$(NEXES),$(notdir $(nexe))) \
           $(OBJDIR) $(SB_OBJDIR) $(SBB_OBJDIR) build/*.bloat.json
 
 clean-all: clean
         rm -rf build/ crosstest/Output/