Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Unified Diff: Makefile.standalone

Issue 2271053006: Subzero: Add the MIPS=1 makefile option for alternate testing mode. (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Patch Set: Move sandboxed translator build to the end Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Makefile.standalone
diff --git a/Makefile.standalone b/Makefile.standalone
index f3a5d877191cfce20594178941332d77d4d2a227..cb850cd41d45e5c636a2c5ba994d37d834c2233a 100644
--- a/Makefile.standalone
+++ b/Makefile.standalone
@@ -541,6 +541,20 @@ ifdef MINIMAL
check-xtest check-xtest-lite: $(OBJDIR)/pnacl-sz make_symlink runtime
@echo "Crosstests disabled, minimal build"
else
+ifdef MIPS
+check-xtest check-xtest-lite: $(OBJDIR)/pnacl-sz make_symlink runtime \
+ crosstest/test_arith_ll.ll
+ # Do all x8664/native/sse2 tests as a smoke test.
+ # Add in mips32 tests as they come online.
+ ./pydir/crosstest_generator.py -v --lit \
+ --toolchain-root $(TOOLCHAIN_ROOT) \
+ $(FORCEASM_FLAG) \
+ $(FORCEASM_XTEST_EXCLUDES) \
+ -i x8664,native,sse2 \
+ -i mips32,xxx
+ PNACL_BIN_PATH=$(PNACL_BIN_PATH) \
+ $(LLVM_SRC_PATH)/utils/lit/lit.py -sv $(CHECK_XTEST_TESTS)
+else
obucinac 2016/09/01 16:31:20 It appears make -f Makefile.standalone check-xtes
check-xtest: $(OBJDIR)/pnacl-sz make_symlink runtime \
exists-nonsfi-x8632 exists-nonsfi-arm32 crosstest/test_arith_ll.ll
# Do all native/sse2 tests, but only test_vector_ops for native/sse4.1.
@@ -588,6 +602,7 @@ check-xtest-lite: $(OBJDIR)/pnacl-sz make_symlink runtime \
crosstest/test_arith_ll.ll: pydir/gen_test_arith_ll.py
python $< > $@
endif
+endif
check-unit: $(OBJDIR)/run_unittests
$(OBJDIR)/run_unittests
@@ -621,7 +636,12 @@ SPECRUN := --run
./pydir/szbuild_spec2k.py -v \
$(SPECFLAGS) --target=$(TARGETFLAG) $(SPEC) $< $(SPECRUN)
+ifdef MIPS
+# Don't test spec2k on mips32, at least not yet.
+check-spec:
+else
check-spec: exists-spec $(ALLSPEC:=.spec2k)
+endif
check: check-lit check-unit check-xtest
@@ -664,6 +684,25 @@ exists-spec:
exit 1 ; \
fi
+ifdef MIPS
+check-presubmit presubmit: exists-sbtc
+# Make sure clang-format gets run.
+ +make -f Makefile.standalone format
+# Verify MINIMAL build, plus proper usage of REQUIRES in lit tests.
+ +make -f Makefile.standalone \
+ MINIMAL=1 check
+# Check that there are no g++ build errors or warnings.
+ +make -f Makefile.standalone \
+ GPLUSPLUS=1 compile_only
+# Run lit tests, cross tests, and unit tests.
+ +make -f Makefile.standalone \
+ check
+# Check a sandboxed translator build.
+ +make -f Makefile.standalone \
+ DEBUG=1 sb
+# Provide validation of user awesomeness!
+ echo Success
+else
check-presubmit presubmit: exists-nonsfi-x8632 exists-nonsfi-arm32 \
exists-sbtc exists-spec
# Make sure clang-format gets run.
@@ -713,6 +752,7 @@ check-presubmit presubmit: exists-nonsfi-x8632 exists-nonsfi-arm32 \
TARGET=arm32 ALLSPEC='252.eon 254.gap 176.gcc 181.mcf' check-spec
# Provide validation of user awesomeness!
echo Success
+endif
presubmit-lite: exists-nonsfi-x8632 exists-nonsfi-arm32 \
exists-sbtc exists-spec
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698