Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Issue 2269713002: Remove redundant String casts in tests (Closed)

Created:
4 years, 4 months ago by pdr.
Modified:
4 years, 4 months ago
Reviewers:
jbroman
CC:
jbroman, ajuma+watch_chromium.org, blink-reviews, blink-reviews-platform-graphics_chromium.org, Rik, chromium-reviews, danakj+watch_chromium.org, dshwang, drott+blinkwatch_chromium.org, krit, f(malita), Justin Novosad, pdr+graphicswatchlist_chromium.org, rwlbuis, Stephen Chennney
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove redundant String casts in tests Jeremy pointed out in https://codereview.chromium.org/2265453003 that I had some unnecessary String casts in tests. These were cargo-culted from https://codereview.chromium.org/2191233002. In this patch, I've just removed these unnecessary casts. BUG=632096 Committed: https://crrev.com/8e730125ea1bdc5d47f159fed87828ef0a7f0ee2 Cr-Commit-Position: refs/heads/master@{#413511}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -8 lines) Patch
M third_party/WebKit/Source/platform/geometry/FloatBoxTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/geometry/FloatQuadTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/geometry/FloatRoundedRectTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/geometry/IntRectTest.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/geometry/LayoutRectTest.cpp View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
pdr.
Trivial, please CQ if you like it
4 years, 4 months ago (2016-08-22 17:51:18 UTC) #2
jbroman
lgtm
4 years, 4 months ago (2016-08-22 18:04:45 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2269713002/1
4 years, 4 months ago (2016-08-22 18:05:31 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-22 19:43:11 UTC) #6
commit-bot: I haz the power
4 years, 4 months ago (2016-08-22 19:46:01 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8e730125ea1bdc5d47f159fed87828ef0a7f0ee2
Cr-Commit-Position: refs/heads/master@{#413511}

Powered by Google App Engine
This is Rietveld 408576698