Add platform/transforms pretty printers for logging and testing

Add platform/transforms pretty printers for logging and testing

This patch switches from a test-only TransformPrinters to a common
pretty printer format for logging and testing in debug and release.

For example, to print the value of an AffineTransform:
    AffineTransform transform = AffineTransform::translation(3, 4);
    LOG(INFO) << "transform: " << translation.toString();
Which prints:
    transform: "translation(3,4)"

In tests, gtests will automatically call the PrintTo functions. For
example:
    AffineTransform translation = AffineTransform::translation(7, 9);
    AffineTransform rotation;
    rotation.rotate(180);
    EXPECT_EQ(translation, rotation);
Will fail with:
    Actual: "translation(0,0), scale(1,1), angle(3.14159rad), remainder(1,0,0,1)"
    Expected: "translation(7,9)"
    [  FAILED  ] AffineTransformTest.NotEqual (0 ms)

In debuggers, toString() should work as expected. There is also an
optional argument to print the transforms in row-major order.

BUG=632096
Committed: https://crrev.com/54bd1a11aa538122321db5481881cf8603e9bf2e
Cr-Commit-Position: refs/heads/master@{#413504}

[pdr., 2016-08-20 06:27:52]

The CQ bit was checked by pdr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-20 06:28:02]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-20 07:51:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-20 07:51:25]

Dry run: Exceeded global retry quota

[pdr., 2016-08-20 19:36:20]

Description was changed from

==========
Add platform/transforms pretty printers for logging and testing

This patch switches from a test-only TransformPrinters to a common
pretty printer format for logging and testing in debug and release.

For example, to print the value of a LayoutRect:
    AffineTransform translation = AffineTransform::translation(3, 4);
    LOG(INFO) << translation.toString();
Which prints:
    translation(3,4)

In tests, gtests will automatically call the PrintTo functions. In
debuggers, toString() should work as expected.

BUG=632096
==========

to

==========
Add platform/transforms pretty printers for logging and testing

This patch switches from a test-only TransformPrinters to a common
pretty printer format for logging and testing in debug and release.

For example, to print the value of an AffineTransform:
    AffineTransform transform = AffineTransform::translation(3, 4);
    LOG(INFO) << "transform: " << translation.toString();
Which prints:
    transform: "translation(3,4)"

In tests, gtests will automatically call the PrintTo functions. For
example:
    AffineTransform translation = AffineTransform::translation(7, 9);
    AffineTransform rotation;
    rotation.rotate(180);
    EXPECT_EQ(translation, rotation);
Will fail with:
    Actual: "translation(0,0), scale(1,1), angle(3.14159rad),
remainder(1,0,0,1)"
    Expected: "translation(7,9)"
    [  FAILED  ] AffineTransformTest.NotEqual (0 ms)

In debuggers, toString() should work as expected. There is also an
optional argument to print the transforms in row-major order.

BUG=632096
==========

[pdr., 2016-08-20 19:36:21]

pdr@chromium.org changed reviewers:
+ chrishtr@chromium.org, wkorman@chromium.org

[pdr., 2016-08-20 19:36:26]

The CQ bit was checked by pdr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-20 19:36:38]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[pdr., 2016-08-20 19:51:48]

The CQ bit was checked by pdr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-20 19:51:53]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[pdr., 2016-08-20 21:06:07]

pdr@chromium.org changed reviewers:
+ jbroman@chromium.org

[commit-bot: I haz the power, 2016-08-20 21:45:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-20 21:45:49]

Dry run: This issue passed the CQ dry run.

[wkorman, 2016-08-21 16:08:37]

The CQ bit was checked by wkorman@chromium.org

[commit-bot: I haz the power, 2016-08-21 16:08:44]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-21 16:08:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-21 16:08:46]

No L-G-T-M from a valid reviewer yet. 
CQ run can only be started by full committers or once the patch has
received an L-G-T-M from a full committer.
Even if an L-G-T-M may have been provided, it was from a non-committer,
_not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing to do with OWNERS files.

[jbroman, 2016-08-21 16:21:07]

lgtm with nits

https://codereview.chromium.org/2265453003/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/platform/transforms/AffineTransform.cpp (right):

https://codereview.chromium.org/2265453003/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/transforms/AffineTransform.cpp:427:
decomposition.angle,
super-nit: up to you, but I'd expect deg to be more useful in practice (as I
think it's more common in the web and in our unit tests), but up to you.
(rad2deg in wtf/MathExtras.h if you agree)

https://codereview.chromium.org/2265453003/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/platform/transforms/AffineTransformTest.cpp
(right):

https://codereview.chromium.org/2265453003/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/transforms/AffineTransformTest.cpp:15:
EXPECT_EQ(String("identity"), identity.toString());
nit: You shouldn't need the String() wrapper on the expected values.

https://codereview.chromium.org/2265453003/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/platform/transforms/TransformationMatrix.cpp
(right):

https://codereview.chromium.org/2265453003/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/transforms/TransformationMatrix.cpp:1615:
return "degenerate";
nit: maybe the matrix representation above would be more helpful in this case.
Or possibly even both:

return toString(true) + " (degenerate)";

https://codereview.chromium.org/2265453003/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/platform/transforms/TransformationMatrixTest.cpp
(right):

https://codereview.chromium.org/2265453003/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/transforms/TransformationMatrixTest.cpp:105:
EXPECT_EQ(String("degenerate"), zeros.toString());
nit: You shouldn't need to wrap the expected results with String(); it's legal
to apply operator== to a WTF::String and a const char*.

[pdr., 2016-08-22 17:27:35]

Thanks!

https://codereview.chromium.org/2265453003/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/platform/transforms/AffineTransform.cpp (right):

https://codereview.chromium.org/2265453003/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/transforms/AffineTransform.cpp:427:
decomposition.angle,
On 2016/08/21 at 16:21:07, jbroman wrote:
> super-nit: up to you, but I'd expect deg to be more useful in practice (as I
think it's more common in the web and in our unit tests), but up to you.
(rad2deg in wtf/MathExtras.h if you agree)

begrudgingly done. Radians are the one true way but you're right that we mostly
use degrees. When in wrong Rome..

https://codereview.chromium.org/2265453003/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/platform/transforms/AffineTransformTest.cpp
(right):

https://codereview.chromium.org/2265453003/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/transforms/AffineTransformTest.cpp:15:
EXPECT_EQ(String("identity"), identity.toString());
On 2016/08/21 at 16:21:07, jbroman wrote:
> nit: You shouldn't need the String() wrapper on the expected values.

Done. I should remove these from the other tests in
https://codereview.chromium.org/2191233002 as well, but lets do that as a
followup.

https://codereview.chromium.org/2265453003/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/platform/transforms/TransformationMatrix.cpp
(right):

https://codereview.chromium.org/2265453003/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/transforms/TransformationMatrix.cpp:1615:
return "degenerate";
On 2016/08/21 at 16:21:07, jbroman wrote:
> nit: maybe the matrix representation above would be more helpful in this case.
Or possibly even both:
> 
> return toString(true) + " (degenerate)";

Good idea, done.

[pdr., 2016-08-22 17:27:50]

The CQ bit was checked by pdr@chromium.org

[pdr., 2016-08-22 17:27:50]

The patchset sent to the CQ was uploaded after l-g-t-m from jbroman@chromium.org
Link to the patchset: https://codereview.chromium.org/2265453003/#ps80001
(title: "Update per reviewer comments")

[commit-bot: I haz the power, 2016-08-22 17:28:43]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-22 19:27:38]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-08-22 19:30:37]

Description was changed from

==========
Add platform/transforms pretty printers for logging and testing

This patch switches from a test-only TransformPrinters to a common
pretty printer format for logging and testing in debug and release.

For example, to print the value of an AffineTransform:
    AffineTransform transform = AffineTransform::translation(3, 4);
    LOG(INFO) << "transform: " << translation.toString();
Which prints:
    transform: "translation(3,4)"

In tests, gtests will automatically call the PrintTo functions. For
example:
    AffineTransform translation = AffineTransform::translation(7, 9);
    AffineTransform rotation;
    rotation.rotate(180);
    EXPECT_EQ(translation, rotation);
Will fail with:
    Actual: "translation(0,0), scale(1,1), angle(3.14159rad),
remainder(1,0,0,1)"
    Expected: "translation(7,9)"
    [  FAILED  ] AffineTransformTest.NotEqual (0 ms)

In debuggers, toString() should work as expected. There is also an
optional argument to print the transforms in row-major order.

BUG=632096
==========

to

==========
Add platform/transforms pretty printers for logging and testing

This patch switches from a test-only TransformPrinters to a common
pretty printer format for logging and testing in debug and release.

For example, to print the value of an AffineTransform:
    AffineTransform transform = AffineTransform::translation(3, 4);
    LOG(INFO) << "transform: " << translation.toString();
Which prints:
    transform: "translation(3,4)"

In tests, gtests will automatically call the PrintTo functions. For
example:
    AffineTransform translation = AffineTransform::translation(7, 9);
    AffineTransform rotation;
    rotation.rotate(180);
    EXPECT_EQ(translation, rotation);
Will fail with:
    Actual: "translation(0,0), scale(1,1), angle(3.14159rad),
remainder(1,0,0,1)"
    Expected: "translation(7,9)"
    [  FAILED  ] AffineTransformTest.NotEqual (0 ms)

In debuggers, toString() should work as expected. There is also an
optional argument to print the transforms in row-major order.

BUG=632096

Committed: https://crrev.com/54bd1a11aa538122321db5481881cf8603e9bf2e
Cr-Commit-Position: refs/heads/master@{#413504}
==========

[commit-bot: I haz the power, 2016-08-22 19:30:38]

Patchset 5 (id:??) landed as
https://crrev.com/54bd1a11aa538122321db5481881cf8603e9bf2e
Cr-Commit-Position: refs/heads/master@{#413504}