third_party/WebKit/Source/platform/geometry/FloatBoxTest.cpp - Issue 2269713002: Remove redundant String casts in tests

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/Source/platform/geometry/FloatBoxTest.cpp

Issue 2269713002: Remove redundant String casts in tests (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « no previous file | third_party/WebKit/Source/platform/geometry/FloatQuadTest.cpp » ('j') | no next file with comments »

OLD	NEW
1 /*	1 /*

2 * Copyright (C) 2014 Google Inc. All rights reserved.	2 * Copyright (C) 2014 Google Inc. All rights reserved.

3 *	3 *

4 * Redistribution and use in source and binary forms, with or without	4 * Redistribution and use in source and binary forms, with or without

5 * modification, are permitted provided that the following conditions	5 * modification, are permitted provided that the following conditions

6 * are met:	6 * are met:

7 * 1. Redistributions of source code must retain the above copyright	7 * 1. Redistributions of source code must retain the above copyright

8 * notice, this list of conditions and the following disclaimer.	8 * notice, this list of conditions and the following disclaimer.

9 * 2. Redistributions in binary form must reproduce the above copyright	9 * 2. Redistributions in binary form must reproduce the above copyright

10 * notice, this list of conditions and the following disclaimer in the	10 * notice, this list of conditions and the following disclaimer in the

(...skipping 100 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
111 EXPECT_TRUE(box.isEmpty());	111 EXPECT_TRUE(box.isEmpty());

112 box.expandTo(FloatPoint3D(1, 0, 0));	112 box.expandTo(FloatPoint3D(1, 0, 0));

113 EXPECT_TRUE(box.isEmpty());	113 EXPECT_TRUE(box.isEmpty());

114 box.expandTo(FloatPoint3D(0, 1, 0));	114 box.expandTo(FloatPoint3D(0, 1, 0));

115 EXPECT_FALSE(box.isEmpty());	115 EXPECT_FALSE(box.isEmpty());

116 }	116 }

117	117

118 TEST(FloatBoxTest, ToString)	118 TEST(FloatBoxTest, ToString)

119 {	119 {

120 FloatBox box(2, 3, 5, 7, 11, 13);	120 FloatBox box(2, 3, 5, 7, 11, 13);

121 EXPECT_EQ(String("2,3,5 7x11x13"), box.toString());	121 EXPECT_EQ("2,3,5 7x11x13", box.toString());

122 }	122 }

123	123

124 } // namespace blink	124 } // namespace blink

OLD	NEW