Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(201)

Side by Side Diff: third_party/WebKit/Source/platform/geometry/LayoutRectTest.cpp

Issue 2269713002: Remove redundant String casts in tests (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « third_party/WebKit/Source/platform/geometry/IntRectTest.cpp ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "platform/geometry/LayoutRect.h" 5 #include "platform/geometry/LayoutRect.h"
6 6
7 #include "testing/gtest/include/gtest/gtest.h" 7 #include "testing/gtest/include/gtest/gtest.h"
8 #include "wtf/text/WTFString.h" 8 #include "wtf/text/WTFString.h"
9 9
10 namespace blink { 10 namespace blink {
11 11
12 TEST(LayoutRectTest, ToString) 12 TEST(LayoutRectTest, ToString)
13 { 13 {
14 LayoutRect emptyRect = LayoutRect(); 14 LayoutRect emptyRect = LayoutRect();
15 EXPECT_EQ(String("0,0 0x0"), emptyRect.toString()); 15 EXPECT_EQ("0,0 0x0", emptyRect.toString());
16 16
17 LayoutRect rect(1, 2, 3, 4); 17 LayoutRect rect(1, 2, 3, 4);
18 EXPECT_EQ(String("1,2 3x4"), rect.toString()); 18 EXPECT_EQ("1,2 3x4", rect.toString());
19 19
20 LayoutRect granularRect(LayoutUnit(1.6f), LayoutUnit(2.7f), LayoutUnit(3.8f) , LayoutUnit(4.9f)); 20 LayoutRect granularRect(LayoutUnit(1.6f), LayoutUnit(2.7f), LayoutUnit(3.8f) , LayoutUnit(4.9f));
21 EXPECT_EQ(String("1.59375,2.6875 3.79688x4.89063"), granularRect.toString()) ; 21 EXPECT_EQ("1.59375,2.6875 3.79688x4.89063", granularRect.toString());
22 } 22 }
23 23
24 #ifndef NDEBUG 24 #ifndef NDEBUG
25 TEST(LayoutRectTest, InclusiveIntersect) 25 TEST(LayoutRectTest, InclusiveIntersect)
26 { 26 {
27 LayoutRect rect(11, 12, 0, 0); 27 LayoutRect rect(11, 12, 0, 0);
28 EXPECT_TRUE(rect.inclusiveIntersect(LayoutRect(11, 12, 13, 14))); 28 EXPECT_TRUE(rect.inclusiveIntersect(LayoutRect(11, 12, 13, 14)));
29 EXPECT_EQ(rect, LayoutRect(11, 12, 0, 0)); 29 EXPECT_EQ(rect, LayoutRect(11, 12, 0, 0));
30 30
31 rect = LayoutRect(11, 12, 13, 14); 31 rect = LayoutRect(11, 12, 13, 14);
32 EXPECT_TRUE(rect.inclusiveIntersect(LayoutRect(24, 8, 0, 7))); 32 EXPECT_TRUE(rect.inclusiveIntersect(LayoutRect(24, 8, 0, 7)));
33 EXPECT_EQ(rect, LayoutRect(24, 12, 0, 3)); 33 EXPECT_EQ(rect, LayoutRect(24, 12, 0, 3));
34 34
35 rect = LayoutRect(11, 12, 13, 14); 35 rect = LayoutRect(11, 12, 13, 14);
36 EXPECT_TRUE(rect.inclusiveIntersect(LayoutRect(9, 15, 4, 0))); 36 EXPECT_TRUE(rect.inclusiveIntersect(LayoutRect(9, 15, 4, 0)));
37 EXPECT_EQ(rect, LayoutRect(11, 15, 2, 0)); 37 EXPECT_EQ(rect, LayoutRect(11, 15, 2, 0));
38 38
39 rect = LayoutRect(11, 12, 0, 14); 39 rect = LayoutRect(11, 12, 0, 14);
40 EXPECT_FALSE(rect.inclusiveIntersect(LayoutRect(12, 13, 15, 16))); 40 EXPECT_FALSE(rect.inclusiveIntersect(LayoutRect(12, 13, 15, 16)));
41 EXPECT_EQ(rect, LayoutRect()); 41 EXPECT_EQ(rect, LayoutRect());
42 } 42 }
43 #endif 43 #endif
44 44
45 } // namespace blink 45 } // namespace blink
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/platform/geometry/IntRectTest.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698