Extract shared filters and aliasing code

Extract shared filters and aliasing code

There are no visual differences*

In a future CL, tasklist will begin using these new behaviors.

alias.js includes shared behavior for applying and 
unapplying Android and GPU aliases.  

query-column-filter-behavior includes shared behavior for filtering the
columns and data used in bot-filters (and soon in task-filters).

*I fixed quarantine messages in some cases and made app.yaml not
upload bower_components and node_componenets - which keeps the
size of the GAE app 12MB instead of 60+MB.

BUG=631047
Committed: https://github.com/luci/luci-py/commit/6c730d430ec1bb8e0a147adea5a3fd1b0194461b

[kjlubick, 2016-08-22 15:13:54]

Description was changed from

==========
Extract shared filters and aliasing code

In a future CL, tasklist will begin using these new behaviors

BUG=631047
==========

to

==========
Extract shared filters and aliasing code

In a future CL, tasklist will begin using these new behaviors.

common-aliases.html includes shared behavior for applying and 
unapplying Android and GPU aliases.  

query-column-filter includes shared behavior for filtering the
columns and data used in bot-filters (and soon in task-filters).

BUG=631047
==========

[kjlubick, 2016-08-22 15:13:54]

kjlubick@google.com changed reviewers:
+ jcgregorio@google.com, stephana@google.com

[kjlubick, 2016-08-22 15:15:09]

Description was changed from

==========
Extract shared filters and aliasing code

In a future CL, tasklist will begin using these new behaviors.

common-aliases.html includes shared behavior for applying and 
unapplying Android and GPU aliases.  

query-column-filter includes shared behavior for filtering the
columns and data used in bot-filters (and soon in task-filters).

BUG=631047
==========

to

==========
Extract shared filters and aliasing code

There are no visual differences*

In a future CL, tasklist will begin using these new behaviors.

common-aliases.html includes shared behavior for applying and 
unapplying Android and GPU aliases.  

query-column-filter includes shared behavior for filtering the
columns and data used in bot-filters (and soon in task-filters).

*I fixed quarantine messages in some cases and made app.yaml not
upload bower_components and node_componenets - which keeps the
size of the GAE app 12MB instead of 60+MB.

BUG=631047
==========

[stephana, 2016-08-23 12:41:51]

https://codereview.chromium.org/2269643002/diff/40001/appengine/swarming/elem...
File appengine/swarming/elements/res/imp/common/common-aliases.html (right):

https://codereview.chromium.org/2269643002/diff/40001/appengine/swarming/elem...
appengine/swarming/elements/res/imp/common/common-aliases.html:13: <!--Import
this to initialize SwarmingBehaviors-->
IMO, this should be in a JS file.

[jcgregorio, 2016-08-23 13:07:45]

https://codereview.chromium.org/2269643002/diff/40001/appengine/swarming/elem...
File appengine/swarming/elements/res/imp/botlist/bot-list.html (right):

https://codereview.chromium.org/2269643002/diff/40001/appengine/swarming/elem...
appengine/swarming/elements/res/imp/botlist/bot-list.html:320:
SwarmingBehaviors.DynamicTableBehavior,
So we have SwarmingBehaviors.BotListBehavior which can maybe have some of its
attributes overwritten by SwarmingBehaviors.DynamicTableBehavior. And these are
used in one or more elements. There should be a DESIGN.md that explains all the
moving parts and how they relate at a high level.

https://codereview.chromium.org/2269643002/diff/40001/appengine/swarming/elem...
File appengine/swarming/elements/res/imp/common/common-aliases.html (right):

https://codereview.chromium.org/2269643002/diff/40001/appengine/swarming/elem...
appengine/swarming/elements/res/imp/common/common-aliases.html:1: <!--
I normally expect .html files under /res/imp/ to contain element definitions.
Can we come up with a naming convention to distinguish .html files that contain
behaviors? Either /res/imp/common/aliases-behaviors.html, or
/res/imp/behaviors/aliases.html would work for me.

https://codereview.chromium.org/2269643002/diff/40001/appengine/swarming/elem...
appengine/swarming/elements/res/imp/common/common-aliases.html:13: <!--Import
this to initialize SwarmingBehaviors-->
On 2016/08/23 at 12:41:51, stephana wrote:
> IMO, this should be in a JS file.

A JS file can't have <link rel="import" href="swarming-app.html">.

https://codereview.chromium.org/2269643002/diff/40001/appengine/swarming/elem...
File appengine/swarming/elements/res/imp/common/dynamic-table.html (right):

https://codereview.chromium.org/2269643002/diff/40001/appengine/swarming/elem...
appengine/swarming/elements/res/imp/common/dynamic-table.html:268: 
One blank line here.

https://codereview.chromium.org/2269643002/diff/40001/appengine/swarming/elem...
File appengine/swarming/elements/res/imp/common/query-column-filter.html
(right):

https://codereview.chromium.org/2269643002/diff/40001/appengine/swarming/elem...
appengine/swarming/elements/res/imp/common/query-column-filter.html:6: This file
contains most of the logic to create a column filter with query. It is broken up
into two parts: a style dom-module called query-column-filter-style and a
behavior called SwarmingBehaviors.QueryColumnFilter.  This behavior handles
enabling/disabling filters, showing/hiding columns and other features related to
the filtering ui.
Wrap to 100 or 80 chars.

Check other lines below also.

[kjlubick, 2016-08-23 17:43:14]

Description was changed from

==========
Extract shared filters and aliasing code

There are no visual differences*

In a future CL, tasklist will begin using these new behaviors.

common-aliases.html includes shared behavior for applying and 
unapplying Android and GPU aliases.  

query-column-filter includes shared behavior for filtering the
columns and data used in bot-filters (and soon in task-filters).

*I fixed quarantine messages in some cases and made app.yaml not
upload bower_components and node_componenets - which keeps the
size of the GAE app 12MB instead of 60+MB.

BUG=631047
==========

to

==========
Extract shared filters and aliasing code

There are no visual differences*

In a future CL, tasklist will begin using these new behaviors.

alias.js includes shared behavior for applying and 
unapplying Android and GPU aliases.  

query-column-filter-behavior includes shared behavior for filtering the
columns and data used in bot-filters (and soon in task-filters).

*I fixed quarantine messages in some cases and made app.yaml not
upload bower_components and node_componenets - which keeps the
size of the GAE app 12MB instead of 60+MB.

BUG=631047
==========

[kjlubick, 2016-08-23 17:43:19]

https://codereview.chromium.org/2269643002/diff/40001/appengine/swarming/elem...
File appengine/swarming/elements/res/imp/botlist/bot-list.html (right):

https://codereview.chromium.org/2269643002/diff/40001/appengine/swarming/elem...
appengine/swarming/elements/res/imp/botlist/bot-list.html:320:
SwarmingBehaviors.DynamicTableBehavior,
On 2016/08/23 at 13:07:44, jcgregorio wrote:
> So we have SwarmingBehaviors.BotListBehavior which can maybe have some of its
attributes overwritten by SwarmingBehaviors.DynamicTableBehavior. And these are
used in one or more elements. There should be a DESIGN.md that explains all the
moving parts and how they relate at a high level.

Done.

https://codereview.chromium.org/2269643002/diff/40001/appengine/swarming/elem...
File appengine/swarming/elements/res/imp/common/common-aliases.html (right):

https://codereview.chromium.org/2269643002/diff/40001/appengine/swarming/elem...
appengine/swarming/elements/res/imp/common/common-aliases.html:1: <!--
On 2016/08/23 at 13:07:44, jcgregorio wrote:
> I normally expect .html files under /res/imp/ to contain element definitions.
Can we come up with a naming convention to distinguish .html files that contain
behaviors? Either /res/imp/common/aliases-behaviors.html, or
/res/imp/behaviors/aliases.html would work for me.

All behaviors now end in -behavior.html

https://codereview.chromium.org/2269643002/diff/40001/appengine/swarming/elem...
appengine/swarming/elements/res/imp/common/common-aliases.html:13: <!--Import
this to initialize SwarmingBehaviors-->
On 2016/08/23 at 13:07:44, jcgregorio wrote:
> On 2016/08/23 at 12:41:51, stephana wrote:
> > IMO, this should be in a JS file.
> 
> A JS file can't have <link rel="import" href="swarming-app.html">.

This is now a standalone JS.

https://codereview.chromium.org/2269643002/diff/40001/appengine/swarming/elem...
File appengine/swarming/elements/res/imp/common/dynamic-table.html (right):

https://codereview.chromium.org/2269643002/diff/40001/appengine/swarming/elem...
appengine/swarming/elements/res/imp/common/dynamic-table.html:268: 
On 2016/08/23 at 13:07:44, jcgregorio wrote:
> One blank line here.

Done.

https://codereview.chromium.org/2269643002/diff/40001/appengine/swarming/elem...
File appengine/swarming/elements/res/imp/common/query-column-filter.html
(right):

https://codereview.chromium.org/2269643002/diff/40001/appengine/swarming/elem...
appengine/swarming/elements/res/imp/common/query-column-filter.html:6: This file
contains most of the logic to create a column filter with query. It is broken up
into two parts: a style dom-module called query-column-filter-style and a
behavior called SwarmingBehaviors.QueryColumnFilter.  This behavior handles
enabling/disabling filters, showing/hiding columns and other features related to
the filtering ui.
On 2016/08/23 at 13:07:45, jcgregorio wrote:
> Wrap to 100 or 80 chars.
> 
> Check other lines below also.

Done.

[jcgregorio, 2016-08-23 17:58:59]

https://codereview.chromium.org/2269643002/diff/60001/appengine/swarming/elem...
File appengine/swarming/elements/res/imp/botlist/DESIGN.md (right):

https://codereview.chromium.org/2269643002/diff/60001/appengine/swarming/elem...
appengine/swarming/elements/res/imp/botlist/DESIGN.md:5:
+------------->+CommonBehavior+<-----------------+
nit: Can you add a single spacing in the boxes? For example:

  
https://github.com/google/skia-buildbot/blob/d08d005f277e8b65d72e5c5dc16a052b...

https://codereview.chromium.org/2269643002/diff/60001/appengine/swarming/elem...
appengine/swarming/elements/res/imp/botlist/DESIGN.md:19: |<bot-filters>|       
 |    |<bot-list-summary>|  |<bot-list>|
This shows inheritance of behaviors, which is great, but we also have <bot-list>
uses <bot-filters>, and <task-list> which uses <task-filters>. Can you add a
separate composition diagram?

[kjlubick, 2016-08-23 19:13:56]

https://codereview.chromium.org/2269643002/diff/60001/appengine/swarming/elem...
File appengine/swarming/elements/res/imp/botlist/DESIGN.md (right):

https://codereview.chromium.org/2269643002/diff/60001/appengine/swarming/elem...
appengine/swarming/elements/res/imp/botlist/DESIGN.md:5:
+------------->+CommonBehavior+<-----------------+
On 2016/08/23 at 17:58:59, jcgregorio wrote:
> nit: Can you add a single spacing in the boxes? For example:
> 
>   
https://github.com/google/skia-buildbot/blob/d08d005f277e8b65d72e5c5dc16a052b...

Done.

https://codereview.chromium.org/2269643002/diff/60001/appengine/swarming/elem...
appengine/swarming/elements/res/imp/botlist/DESIGN.md:19: |<bot-filters>|       
 |    |<bot-list-summary>|  |<bot-list>|
On 2016/08/23 at 17:58:59, jcgregorio wrote:
> This shows inheritance of behaviors, which is great, but we also have
<bot-list> uses <bot-filters>, and <task-list> which uses <task-filters>. Can
you add a separate composition diagram?

I don't think I need a diagram for this.  See line "`<bot-list>` is the main
element and composes the others."

Nothing else is composed of anything else

[jcgregorio, 2016-08-24 14:48:28]

LGTM modulo the nit with the docs.

https://codereview.chromium.org/2269643002/diff/80001/appengine/swarming/elem...
File appengine/swarming/elements/res/imp/botlist/DESIGN.md (right):

https://codereview.chromium.org/2269643002/diff/80001/appengine/swarming/elem...
appengine/swarming/elements/res/imp/botlist/DESIGN.md:1: This is a highlevel
overview of the pieces that make up botlist.
Move this up from /res/imp/botlist to /res/imp since the behaviors are used
across more than just the botlist elements. 

The diagram doesn't need to change, just add a note that this is an example
ofhow the behaviors are used by <bot-list>.

[kjlubick, 2016-08-24 15:06:32]

https://codereview.chromium.org/2269643002/diff/80001/appengine/swarming/elem...
File appengine/swarming/elements/res/imp/botlist/DESIGN.md (right):

https://codereview.chromium.org/2269643002/diff/80001/appengine/swarming/elem...
appengine/swarming/elements/res/imp/botlist/DESIGN.md:1: This is a highlevel
overview of the pieces that make up botlist.
On 2016/08/24 at 14:48:27, jcgregorio wrote:
> Move this up from /res/imp/botlist to /res/imp since the behaviors are used
across more than just the botlist elements. 
> 
> The diagram doesn't need to change, just add a note that this is an example
ofhow the behaviors are used by <bot-list>.

Done.

[kjlubick, 2016-08-24 15:06:52]

The CQ bit was checked by kjlubick@google.com

[kjlubick, 2016-08-24 15:06:53]

The patchset sent to the CQ was uploaded after l-g-t-m from
jcgregorio@google.com
Link to the patchset: https://codereview.chromium.org/2269643002/#ps100001
(title: "Address nit")

[commit-bot: I haz the power, 2016-08-24 15:07:07]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-24 15:07:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-24 15:07:09]

No L-G-T-M from a valid reviewer yet. 
CQ run can only be started by full committers or once the patch has
received an L-G-T-M from a full committer.
Even if an L-G-T-M may have been provided, it was from a non-committer,
_not_ a full super star committer.
Committers are members of the group "project-infra-committers".
Note that this has nothing to do with OWNERS files.

[KevinL, 2016-08-24 15:07:11]

kjlubick@chromium.org changed reviewers:
+ kjlubick@chromium.org

[KevinL, 2016-08-24 15:07:12]

lgtm

[KevinL, 2016-08-24 15:07:17]

The CQ bit was checked by kjlubick@chromium.org

[commit-bot: I haz the power, 2016-08-24 15:07:22]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-24 15:10:44]

Description was changed from

==========
Extract shared filters and aliasing code

There are no visual differences*

In a future CL, tasklist will begin using these new behaviors.

alias.js includes shared behavior for applying and 
unapplying Android and GPU aliases.  

query-column-filter-behavior includes shared behavior for filtering the
columns and data used in bot-filters (and soon in task-filters).

*I fixed quarantine messages in some cases and made app.yaml not
upload bower_components and node_componenets - which keeps the
size of the GAE app 12MB instead of 60+MB.

BUG=631047
==========

to

==========
Extract shared filters and aliasing code

There are no visual differences*

In a future CL, tasklist will begin using these new behaviors.

alias.js includes shared behavior for applying and 
unapplying Android and GPU aliases.  

query-column-filter-behavior includes shared behavior for filtering the
columns and data used in bot-filters (and soon in task-filters).

*I fixed quarantine messages in some cases and made app.yaml not
upload bower_components and node_componenets - which keeps the
size of the GAE app 12MB instead of 60+MB.

BUG=631047

Committed:
https://github.com/luci/luci-py/commit/6c730d430ec1bb8e0a147adea5a3fd1b0194461b
==========

[commit-bot: I haz the power, 2016-08-24 15:10:45]

Committed patchset #6 (id:100001) as
https://github.com/luci/luci-py/commit/6c730d430ec1bb8e0a147adea5a3fd1b0194461b