Add filter to task-list

Add filter to task-list

The two big things in this CL are adding in the filtering mechanism (very similar to filtering bot-list) and migrating task-list-data to use sk.request.

In the task list, you can dynamically choose your columns and quickly see the state of tasks, and cancel pending tasks.

Assembling the tags (in task-list-data) is a bit trickier than the dimensions was for the botlist because there are many more tasks than bots, so the cron job can only run once per hour for the last hour's worth of data.  

BUG=631047
Committed: https://github.com/luci/luci-py/commit/deb944d9ff75f7c9c6d66072601cdb2c2dbed971

[kjlubick, 2016-08-24 20:11:27]

Description was changed from

==========
Make task list filters

BUG=
==========

to

==========
Add filter to task-list

The two big things in this CL are adding in the filtering mechanism (very
similar to filtering bot-list) and migrating task-list-data to use sk.request.

In the task list, you can dynamically choose your columns and quickly see the
state of tasks, and cancel pending tasks.

Assembling the tags (in task-list-data) is a bit trickier than the dimensions
was for the botlist because there are many more tasks than bots, so the cron job
can only run once per hour for the last hour's worth of data.  

BUG=
==========

[kjlubick, 2016-08-24 20:11:44]

Description was changed from

==========
Add filter to task-list

The two big things in this CL are adding in the filtering mechanism (very
similar to filtering bot-list) and migrating task-list-data to use sk.request.

In the task list, you can dynamically choose your columns and quickly see the
state of tasks, and cancel pending tasks.

Assembling the tags (in task-list-data) is a bit trickier than the dimensions
was for the botlist because there are many more tasks than bots, so the cron job
can only run once per hour for the last hour's worth of data.  

BUG=
==========

to

==========
Add filter to task-list

The two big things in this CL are adding in the filtering mechanism (very
similar to filtering bot-list) and migrating task-list-data to use sk.request.

In the task list, you can dynamically choose your columns and quickly see the
state of tasks, and cancel pending tasks.

Assembling the tags (in task-list-data) is a bit trickier than the dimensions
was for the botlist because there are many more tasks than bots, so the cron job
can only run once per hour for the last hour's worth of data.  

BUG=631047
==========

[kjlubick, 2016-08-24 20:14:55]

kjlubick@google.com changed reviewers:
+ jcgregorio@google.com, stephana@google.com

[kjlubick, 2016-08-24 20:14:56]

On live data
https://2288-384b2db-tainted-kjlubick-dot-chromium-swarm-dev.appspot.com

Demo with better mock data
https://goto.google.com/ejfjw

Filter at top
https://screenshot.googleplex.com/9QYi5zezSSL

Clickable pending button
https://screenshot.googleplex.com/VMMuHR3D662

[jcgregorio, 2016-08-24 20:39:07]

LGTM with some nits.

https://codereview.chromium.org/2266133002/diff/80001/appengine/swarming/elem...
File appengine/swarming/elements/res/imp/common/common-behavior.html (right):

https://codereview.chromium.org/2266133002/diff/80001/appengine/swarming/elem...
appengine/swarming/elements/res/imp/common/common-behavior.html:32: // is
undefined. Clients should check that bindTo is not falsey.
Note that params are passed in as an obj.

https://codereview.chromium.org/2266133002/diff/80001/appengine/swarming/elem...
File appengine/swarming/elements/res/imp/tasklist/task-filters.html (right):

https://codereview.chromium.org/2266133002/diff/80001/appengine/swarming/elem...
appengine/swarming/elements/res/imp/tasklist/task-filters.html:170: 
No blank line.

https://codereview.chromium.org/2266133002/diff/80001/appengine/swarming/elem...
appengine/swarming/elements/res/imp/tasklist/task-filters.html:172: 
No blank line.

[kjlubick, 2016-08-25 12:39:10]

https://codereview.chromium.org/2266133002/diff/80001/appengine/swarming/elem...
File appengine/swarming/elements/res/imp/common/common-behavior.html (right):

https://codereview.chromium.org/2266133002/diff/80001/appengine/swarming/elem...
appengine/swarming/elements/res/imp/common/common-behavior.html:32: // is
undefined. Clients should check that bindTo is not falsey.
On 2016/08/24 at 20:39:07, jcgregorio wrote:
> Note that params are passed in as an obj.

Done.

https://codereview.chromium.org/2266133002/diff/80001/appengine/swarming/elem...
File appengine/swarming/elements/res/imp/tasklist/task-filters.html (right):

https://codereview.chromium.org/2266133002/diff/80001/appengine/swarming/elem...
appengine/swarming/elements/res/imp/tasklist/task-filters.html:170: 
On 2016/08/24 at 20:39:07, jcgregorio wrote:
> No blank line.

Done.

https://codereview.chromium.org/2266133002/diff/80001/appengine/swarming/elem...
appengine/swarming/elements/res/imp/tasklist/task-filters.html:172: 
On 2016/08/24 at 20:39:07, jcgregorio wrote:
> No blank line.

Done.

[stephana, 2016-08-25 17:56:58]

On 2016/08/25 12:39:10, kjlubick wrote:
>
https://codereview.chromium.org/2266133002/diff/80001/appengine/swarming/elem...
> File appengine/swarming/elements/res/imp/common/common-behavior.html (right):
> 
>
https://codereview.chromium.org/2266133002/diff/80001/appengine/swarming/elem...
> appengine/swarming/elements/res/imp/common/common-behavior.html:32: // is
> undefined. Clients should check that bindTo is not falsey.
> On 2016/08/24 at 20:39:07, jcgregorio wrote:
> > Note that params are passed in as an obj.
> 
> Done.
> 
>
https://codereview.chromium.org/2266133002/diff/80001/appengine/swarming/elem...
> File appengine/swarming/elements/res/imp/tasklist/task-filters.html (right):
> 
>
https://codereview.chromium.org/2266133002/diff/80001/appengine/swarming/elem...
> appengine/swarming/elements/res/imp/tasklist/task-filters.html:170: 
> On 2016/08/24 at 20:39:07, jcgregorio wrote:
> > No blank line.
> 
> Done.
> 
>
https://codereview.chromium.org/2266133002/diff/80001/appengine/swarming/elem...
> appengine/swarming/elements/res/imp/tasklist/task-filters.html:172: 
> On 2016/08/24 at 20:39:07, jcgregorio wrote:
> > No blank line.
> 
> Done.

lgtm

[kjlubick, 2016-08-25 17:57:41]

The CQ bit was checked by kjlubick@google.com

[kjlubick, 2016-08-25 17:57:41]

The patchset sent to the CQ was uploaded after l-g-t-m from
jcgregorio@google.com
Link to the patchset: https://codereview.chromium.org/2266133002/#ps120001
(title: "Fix default sort")

[KevinL, 2016-08-25 17:57:47]

kjlubick@chromium.org changed reviewers:
+ kjlubick@chromium.org

[KevinL, 2016-08-25 17:57:47]

lgtm

[commit-bot: I haz the power, 2016-08-25 17:57:48]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-25 18:00:46]

Description was changed from

==========
Add filter to task-list

The two big things in this CL are adding in the filtering mechanism (very
similar to filtering bot-list) and migrating task-list-data to use sk.request.

In the task list, you can dynamically choose your columns and quickly see the
state of tasks, and cancel pending tasks.

Assembling the tags (in task-list-data) is a bit trickier than the dimensions
was for the botlist because there are many more tasks than bots, so the cron job
can only run once per hour for the last hour's worth of data.  

BUG=631047
==========

to

==========
Add filter to task-list

The two big things in this CL are adding in the filtering mechanism (very
similar to filtering bot-list) and migrating task-list-data to use sk.request.

In the task list, you can dynamically choose your columns and quickly see the
state of tasks, and cancel pending tasks.

Assembling the tags (in task-list-data) is a bit trickier than the dimensions
was for the botlist because there are many more tasks than bots, so the cron job
can only run once per hour for the last hour's worth of data.  

BUG=631047

Committed:
https://github.com/luci/luci-py/commit/deb944d9ff75f7c9c6d66072601cdb2c2dbed971
==========

[commit-bot: I haz the power, 2016-08-25 18:00:47]

Committed patchset #7 (id:120001) as
https://github.com/luci/luci-py/commit/deb944d9ff75f7c9c6d66072601cdb2c2dbed971