appengine/swarming/elements/res/imp/botlist/DESIGN.md - Issue 2269643002: Extract shared filters and aliasing code

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: appengine/swarming/elements/res/imp/botlist/DESIGN.md

Issue 2269643002: Extract shared filters and aliasing code (Closed) Base URL: https://chromium.googlesource.com/external/github.com/luci/luci-py@master

Patch Set: Add spacing Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 This is a highlevel overview of the pieces that make up botlist.
	jcgregorio 2016/08/24 14:48:27 Move this up from /res/imp/botlist to /res/imp sin Move this up from /res/imp/botlist to /res/imp since the behaviors are used across more than just the botlist elements. The diagram doesn't need to change, just add a note that this is an example ofhow the behaviors are used by <bot-list>. kjlubick 2016/08/24 15:06:32 Done. Show quoted text On 2016/08/24 at 14:48:27, jcgregorio wrote: > Move this up from /res/imp/botlist to /res/imp since the behaviors are used across more than just the botlist elements. > > The diagram doesn't need to change, just add a note that this is an example ofhow the behaviors are used by <bot-list>. Done.
	2

	3 ```

	4 +----------------+

	5 \| \|

	6 +------------->+ CommonBehavior +<-----------------+

	7 \| \| \| \|

	8 \| +------+---------+ \|

	9 \| ^ \|

	10 \| \| \|

	11 \| \| \|

	12 \| \| \|

	13 +--------+----------+ +----+------------+ +-------+--------------+

	14 \| \| \| \| \| \|

	15 \| QueryColumnFilter \| \| BotListBehavior \| \| DynamicTableBehavior \|

	16 \| \| \| \| \| \|

	17 +-------------------+ +-----------------+ +----------------------+

	18 ^ +-------------^ ^ ^ ^-------------------+ ^

	19 \| \| \| \| \| \|

	20 \| \| \| +---+ \| \|

	21 \| \| \| \| \| \|

	22 +----+--+-------+ \| +-----+--------------+ +-----+------+

	23 \| \| \| \| \| \| \|

	24 \| <bot-filters> \| \| \| <bot-list-summary> \| \| <bot-list> \|

	25 \| \| \| \| \| \| \|

	26 +---------------+ \| +--------------------+ +------------+

	27 \| +-----------------+

	28 \| \| \|

	29 +-----+ <bot-list-data> \|

	30 \| \|

	31 +-----------------+

	32 ```

	33

	34 Although methods defined in the various behaviors could be overwritten by each

	35 other, this is not done.

	36

	37 `<bot-list>` is the main element and composes the others.

OLD	NEW

« no previous file with comments | « appengine/swarming/elements/build/js/js.js ('k') | appengine/swarming/elements/res/imp/botlist/bot-filters.html » ('j') | no next file with comments »

OLD	NEW
(Empty)
	1 This is a highlevel overview of the pieces that make up botlist.
	jcgregorio 2016/08/24 14:48:27 Move this up from /res/imp/botlist to /res/imp sin Move this up from /res/imp/botlist to /res/imp since the behaviors are used across more than just the botlist elements. The diagram doesn't need to change, just add a note that this is an example ofhow the behaviors are used by <bot-list>. kjlubick 2016/08/24 15:06:32 Done. Show quoted text On 2016/08/24 at 14:48:27, jcgregorio wrote: > Move this up from /res/imp/botlist to /res/imp since the behaviors are used across more than just the botlist elements. > > The diagram doesn't need to change, just add a note that this is an example ofhow the behaviors are used by <bot-list>. Done.
	2

	3 ```

	4 +----------------+

	5 \| \|

	6 +------------->+ CommonBehavior +<-----------------+

	7 \| \| \| \|

	8 \| +------+---------+ \|

	9 \| ^ \|

	10 \| \| \|

	11 \| \| \|

	12 \| \| \|

	13 +--------+----------+ +----+------------+ +-------+--------------+

	14 \| \| \| \| \| \|

	15 \| QueryColumnFilter \| \| BotListBehavior \| \| DynamicTableBehavior \|

	16 \| \| \| \| \| \|

	17 +-------------------+ +-----------------+ +----------------------+

	18 ^ +-------------^ ^ ^ ^-------------------+ ^

	19 \| \| \| \| \| \|

	20 \| \| \| +---+ \| \|

	21 \| \| \| \| \| \|

	22 +----+--+-------+ \| +-----+--------------+ +-----+------+

	23 \| \| \| \| \| \| \|

	24 \| <bot-filters> \| \| \| <bot-list-summary> \| \| <bot-list> \|

	25 \| \| \| \| \| \| \|

	26 +---------------+ \| +--------------------+ +------------+

	27 \| +-----------------+

	28 \| \| \|

	29 +-----+ <bot-list-data> \|

	30 \| \|

	31 +-----------------+

	32 ```

	33

	34 Although methods defined in the various behaviors could be overwritten by each

	35 other, this is not done.

	36

	37 `<bot-list>` is the main element and composes the others.

OLD	NEW