appengine/swarming/elements/res/imp/botlist/DESIGN.md - Issue 2269643002: Extract shared filters and aliasing code

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: appengine/swarming/elements/res/imp/botlist/DESIGN.md

Issue 2269643002: Extract shared filters and aliasing code (Closed) Base URL: https://chromium.googlesource.com/external/github.com/luci/luci-py@master

Patch Set: Add Design.md Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 This is a highlevel overview of the pieces that make up botlist.

	2

	3 ```

	4 +--------------+

	5 +------------->+CommonBehavior+<-----------------+
	jcgregorio 2016/08/23 17:58:59 nit: Can you add a single spacing in the boxes? Fo nit: Can you add a single spacing in the boxes? For example: https://github.com/google/skia-buildbot/blob/d08d005f277e8b65d72e5c5dc16a052b... kjlubick 2016/08/23 19:13:56 Done. Show quoted text On 2016/08/23 at 17:58:59, jcgregorio wrote: > nit: Can you add a single spacing in the boxes? For example: > > https://github.com/google/skia-buildbot/blob/d08d005f277e8b65d72e5c5dc16a052b... Done.
	6 \| +------+-------+ \|

	7 \| ^ \|

	8 \| \| \|

	9 \| \| \|

	10 \| \| \|

	11 +--------+--------+ +------+--------+ +---------+----------+

	12 \|QueryColumnFilter\| \|BotListBehavior\| \|DynamicTableBehavior\|

	13 +-----------------+ +---------------+ +--------------------+

	14 ^ +-------------^ ^ ^ ^-------------------+ ^

	15 \| \| \| \| \| \|

	16 \| \| \| +---+ \| \|

	17 \| \| \| \| \| \|

	18 +----+--+-----+ \| +-----+------------+ +-+---+----+

	19 \|<bot-filters>\| \| \|<bot-list-summary>\| \|<bot-list>\|
	jcgregorio 2016/08/23 17:58:59 This shows inheritance of behaviors, which is grea This shows inheritance of behaviors, which is great, but we also have <bot-list> uses <bot-filters>, and <task-list> which uses <task-filters>. Can you add a separate composition diagram? kjlubick 2016/08/23 19:13:56 I don't think I need a diagram for this. See line Show quoted text On 2016/08/23 at 17:58:59, jcgregorio wrote: > This shows inheritance of behaviors, which is great, but we also have <bot-list> uses <bot-filters>, and <task-list> which uses <task-filters>. Can you add a separate composition diagram? I don't think I need a diagram for this. See line "`<bot-list>` is the main element and composes the others." Nothing else is composed of anything else
	20 +-------------+ \| +------------------+ +----------+

	21 \| +---------------+

	22 +-----+<bot-list-data>\|

	23 +---------------+

	24 ```

	25

	26 Although methods defined in the various behaviors could be overwritten by each

	27 other, this is not done.

	28

	29 `<bot-list>` is the main element and composes the others.

OLD	NEW

« no previous file with comments | « appengine/swarming/elements/build/js/js.js ('k') | appengine/swarming/elements/res/imp/botlist/bot-filters.html » ('j') | no next file with comments »