Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2269263002: Make all the rest of the recipes explicitly specify GIT_MODE (Closed)

Created:
4 years, 4 months ago by agable
Modified:
4 years, 3 months ago
CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/build.git@master
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

Make all the rest of the recipes explicitly specify GIT_MODE BUG=640251 Committed: https://chromium.googlesource.com/chromium/tools/build/+/eac0c99f5e54e20af75ce3277a42f2c31c614338

Patch Set 1 #

Patch Set 2 : Make all the rest of the recipes explicitly specify GIT_MODE #

Patch Set 3 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+761 lines, -167 lines) Patch
M scripts/slave/recipe_modules/chromedriver/example.py View 1 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipe_modules/chromedriver/example.expected/Android_ChromeDriver_basic.json View 1 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipe_modules/chromedriver/example.expected/Android_ChromeDriver_commit_already_in_logs.json View 1 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipe_modules/chromedriver/example.expected/Android_ChromeDriver_download_logs_failure.json View 1 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipe_modules/chromedriver/example.expected/Android_ChromeDriver_test_failure.json View 1 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipe_modules/chromedriver/example.expected/Android_ChromeDriver_unexpected_prebuilt.json View 1 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipe_modules/chromite/api.py View 1 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipe_modules/chromium_tests/example.py View 1 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipe_modules/chromium_tests/example.expected/basic.json View 1 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipe_modules/emulator/example.py View 1 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipe_modules/emulator/example.expected/Disable_settings_after_launch_emulator_test_basic.json View 1 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipe_modules/legion/example.py View 1 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipe_modules/legion/example.expected/basic.json View 1 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipe_modules/pgo/api.py View 1 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipe_modules/pgo/example.expected/full_chromium_pgo_test_Test_builder.json View 1 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipe_modules/pgo/example.expected/full_chromium_pgo_test_Test_builder_benchmark_failure.json View 1 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipe_modules/recipe_tryjob/api.py View 1 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipe_modules/skia/api.py View 1 1 chunk +2 lines, -1 line 0 comments Download
M scripts/slave/recipe_modules/webrtc/api.py View 1 1 chunk +2 lines, -1 line 0 comments Download
M scripts/slave/recipes/blink_downstream.py View 1 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/blink_downstream.expected/full_client_v8_fyi_V8_Blink_Linux_64___ignition_fail.json View 1 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/blink_downstream.expected/full_client_v8_fyi_V8_Blink_Linux_64___ignition_pass.json View 1 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/blink_downstream.expected/full_client_v8_fyi_V8_Blink_Linux_64__dbg__fail.json View 1 2 chunks +2 lines, -2 lines 0 comments Download
M scripts/slave/recipes/blink_downstream.expected/full_client_v8_fyi_V8_Blink_Linux_64__dbg__pass.json View 1 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/blink_downstream.expected/full_client_v8_fyi_V8_Blink_Linux_64_fail.json View 1 2 chunks +2 lines, -2 lines 0 comments Download
M scripts/slave/recipes/blink_downstream.expected/full_client_v8_fyi_V8_Blink_Linux_64_pass.json View 1 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/blink_downstream.expected/full_client_v8_fyi_V8_Blink_Mac_fail.json View 1 2 chunks +2 lines, -2 lines 0 comments Download
M scripts/slave/recipes/blink_downstream.expected/full_client_v8_fyi_V8_Blink_Mac_pass.json View 1 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/blink_downstream.expected/full_client_v8_fyi_V8_Blink_Win_fail.json View 1 2 chunks +2 lines, -2 lines 0 comments Download
M scripts/slave/recipes/blink_downstream.expected/full_client_v8_fyi_V8_Blink_Win_pass.json View 1 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/blink_downstream.expected/minimal_pass_continues.json View 1 2 chunks +2 lines, -2 lines 0 comments Download
M scripts/slave/recipes/blink_downstream.expected/too_many_failures_for_retcode.json View 1 2 chunks +2 lines, -2 lines 0 comments Download
M scripts/slave/recipes/blink_downstream.expected/webkit_tests_interrupted.json View 1 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/blink_downstream.expected/webkit_tests_unexpected_error.json View 1 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/boringssl.py View 1 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/boringssl_docs.py View 1 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/catapult.py View 1 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/catapult.expected/android.json View 1 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/catapult.expected/basic.json View 1 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/catapult_cron.py View 1 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/catapult_cron.expected/basic.json View 1 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/chromedriver.py View 1 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/chromedriver.expected/Android_ChromeDriver_Tests__dbg__basic.json View 1 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/chromedriver.expected/Android_ChromeDriver_Tests__dbg__test_failure.json View 1 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/chromium_pgo.expected/full_chromium_fyi_Chromium_Win_PGO_Builder.json View 1 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/chromium_pgo.expected/full_chromium_fyi_Chromium_Win_x64_PGO_Builder.json View 1 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/chromium_pgo.expected/full_tryserver_chromium_win_win_pgo.json View 1 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/closure_compilation.py View 1 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/closure_compilation.expected/closure_compilation_fyi.json View 1 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/closure_compilation.expected/closure_compilation_try.json View 1 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/crashpad/continuous.py View 1 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/crashpad/continuous.expected/crashpad_mac_dbg.json View 1 4 chunks +40 lines, -3 lines 0 comments Download
M scripts/slave/recipes/crashpad/continuous.expected/crashpad_mac_dbg_clobber.json View 1 4 chunks +40 lines, -3 lines 0 comments Download
M scripts/slave/recipes/crashpad/continuous.expected/crashpad_mac_rel.json View 1 4 chunks +40 lines, -3 lines 0 comments Download
M scripts/slave/recipes/crashpad/continuous.expected/crashpad_mac_rel_clobber.json View 1 4 chunks +40 lines, -3 lines 0 comments Download
M scripts/slave/recipes/crashpad/continuous.expected/crashpad_win_x64_dbg.json View 1 4 chunks +40 lines, -3 lines 0 comments Download
M scripts/slave/recipes/crashpad/continuous.expected/crashpad_win_x64_dbg_clobber.json View 1 4 chunks +40 lines, -3 lines 0 comments Download
M scripts/slave/recipes/crashpad/continuous.expected/crashpad_win_x64_rel.json View 1 4 chunks +40 lines, -3 lines 0 comments Download
M scripts/slave/recipes/crashpad/continuous.expected/crashpad_win_x64_rel_clobber.json View 1 4 chunks +40 lines, -3 lines 0 comments Download
M scripts/slave/recipes/crashpad/continuous.expected/crashpad_win_x86_dbg.json View 1 4 chunks +40 lines, -3 lines 0 comments Download
M scripts/slave/recipes/crashpad/continuous.expected/crashpad_win_x86_dbg_clobber.json View 1 4 chunks +40 lines, -3 lines 0 comments Download
M scripts/slave/recipes/crashpad/continuous.expected/crashpad_win_x86_rel.json View 1 4 chunks +40 lines, -3 lines 0 comments Download
M scripts/slave/recipes/crashpad/continuous.expected/crashpad_win_x86_rel_clobber.json View 1 4 chunks +40 lines, -3 lines 0 comments Download
M scripts/slave/recipes/crashpad/continuous.expected/crashpad_win_x86_wow64_dbg.json View 1 4 chunks +40 lines, -3 lines 0 comments Download
M scripts/slave/recipes/crashpad/continuous.expected/crashpad_win_x86_wow64_dbg_clobber.json View 1 4 chunks +40 lines, -3 lines 0 comments Download
M scripts/slave/recipes/crashpad/continuous.expected/crashpad_win_x86_wow64_rel.json View 1 4 chunks +40 lines, -3 lines 0 comments Download
M scripts/slave/recipes/crashpad/continuous.expected/crashpad_win_x86_wow64_rel_clobber.json View 1 4 chunks +40 lines, -3 lines 0 comments Download
M scripts/slave/recipes/cros/cbuildbot.expected/chromiumos_chromium_builder.json View 1 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/cros/cbuildbot.expected/chromiumos_coverage.json View 1 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/cros/cbuildbot.expected/chromiumos_paladin.json View 1 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/cros/cbuildbot.expected/chromiumos_paladin_manifest_failure.json View 1 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/cros/cbuildbot_tryjob.expected/basic_compressed.json View 1 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/cros/cbuildbot_tryjob.expected/external.json View 1 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/cros/cbuildbot_tryjob.expected/internal.json View 1 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/cros/cbuildbot_tryjob.expected/pre_cq_buildbucket_config.json View 1 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/cros/cbuildbot_tryjob.expected/unknown_config.json View 1 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/custom_tabs_client.py View 1 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/custom_tabs_client.expected/basic.json View 1 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/emulator.py View 1 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/emulator.expected/Android_Tests__x86_emulator__test_basic.json View 1 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/emulator.expected/Android_Tests__x86_emulator__test_fail.json View 1 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/gyp.py View 1 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/gyp.expected/fake_test.json View 1 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/legion/legion.py View 1 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/legion/legion.expected/basic.json View 1 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/libyuv/libyuv.py View 1 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/mojo.py View 1 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/mojo.expected/mojo_android_builder.json View 1 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/mojo.expected/mojo_android_builder_tests_dbg.json View 1 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/mojo.expected/mojo_android_builder_tests_dbg_fail_device_check.json View 1 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/mojo.expected/mojo_android_dbg.json View 1 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/mojo.expected/mojo_android_official.json View 1 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/mojo.expected/mojo_linux.json View 1 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/mojo.expected/mojo_linux_asan.json View 1 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/mojo.expected/mojo_linux_asan_dbg.json View 1 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/mojo.expected/mojo_linux_dbg.json View 1 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/mojo.expected/mojo_linux_perf.json View 1 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/mojo.expected/mojo_linux_try.json View 1 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/mojo.expected/mojo_win_dbg.json View 1 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/nacl/sdk.py View 1 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/nacl/sdk.expected/basic.json View 1 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/nacl/sdk_build.py View 1 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/nacl/sdk_build.expected/basic.json View 1 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/nacl_ports.py View 1 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/nacl_ports.expected/linux.json View 1 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/ndk/ndk_buildbot.expected/basic.json View 1 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/ozone_ecs.py View 1 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/ozone_ecs.expected/basic.json View 1 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/ozone_ecs.expected/check_ecs_deps_fail.json View 1 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/ozone_ecs.expected/trybot.json View 1 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/perf/telemetry_harness_upload.py View 1 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/perf/telemetry_harness_upload.expected/basic.json View 1 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/run_presubmit.py View 1 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/run_presubmit.expected/catapult.json View 1 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/run_presubmit.expected/chromium.json View 1 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/run_presubmit.expected/chromium_dry_run.json View 1 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/run_presubmit.expected/chromium_with_auth.json View 1 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/run_presubmit.expected/fake_svn_master.json View 1 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/run_presubmit.expected/gyp.json View 1 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/run_presubmit.expected/internal_deps.json View 1 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/run_presubmit.expected/master_deps.json View 1 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/run_presubmit.expected/nacl.json View 1 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/run_presubmit.expected/presubmit-failure.json View 1 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/run_presubmit.expected/presubmit-infra-failure.json View 1 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/run_presubmit.expected/slave_deps.json View 1 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/run_presubmit.expected/v8.json View 1 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/run_presubmit.expected/webports.json View 1 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/wasm_llvm.py View 1 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/wasm_llvm.expected/linux.json View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 21 (11 generated)
agable
4 years, 4 months ago (2016-08-24 20:52:56 UTC) #4
martiniss
lgtm
4 years, 4 months ago (2016-08-24 21:47:09 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2269263002/10001
4 years, 4 months ago (2016-08-24 22:16:55 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: Build Presubmit on luci.infra.try (JOB_FAILED, https://luci-milo.appspot.com/swarming/task/30d776e89ce0f910)
4 years, 4 months ago (2016-08-24 22:26:24 UTC) #9
agable
+sergeyberezin for OWNERS on the chromium_tests/example.py
4 years, 4 months ago (2016-08-24 22:27:01 UTC) #11
Sergey Berezin
lgtm
4 years, 4 months ago (2016-08-24 22:48:57 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2269263002/30001
4 years, 4 months ago (2016-08-24 22:50:12 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: Recipe Roll Downstream Tester on luci.infra.try (JOB_FAILED, https://luci-milo.appspot.com/swarming/task/30d7973249835e10)
4 years, 4 months ago (2016-08-24 23:04:26 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2269263002/30001
4 years, 3 months ago (2016-08-25 02:47:53 UTC) #19
commit-bot: I haz the power
4 years, 3 months ago (2016-08-25 02:56:56 UTC) #21
Message was sent while issue was closed. 
Committed patchset #3 (id:30001) as
https://chromium.googlesource.com/chromium/tools/build/+/eac0c99f5e54e20af75c...

Powered by Google App Engine
This is Rietveld 408576698