Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Side by Side Diff: scripts/slave/recipes/run_presubmit.py

Issue 2269263002: Make all the rest of the recipes explicitly specify GIT_MODE (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@master
Patch Set: Rebase Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 # Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 DEPS = [ 5 DEPS = [
6 'depot_tools/bot_update', 6 'depot_tools/bot_update',
7 'depot_tools/gclient', 7 'depot_tools/gclient',
8 'depot_tools/git', 8 'depot_tools/git',
9 'depot_tools/presubmit', 9 'depot_tools/presubmit',
10 'recipe_engine/json', 10 'recipe_engine/json',
11 'recipe_engine/path', 11 'recipe_engine/path',
12 'recipe_engine/properties', 12 'recipe_engine/properties',
13 'recipe_engine/python', 13 'recipe_engine/python',
14 'recipe_engine/step', 14 'recipe_engine/step',
15 'depot_tools/tryserver', 15 'depot_tools/tryserver',
16 'depot_tools/rietveld', 16 'depot_tools/rietveld',
17 'v8', 17 'v8',
18 'webrtc', 18 'webrtc',
19 ] 19 ]
20 20
21 21
22 def _RunStepsInternal(api): 22 def _RunStepsInternal(api):
23 repo_name = api.properties['repo_name'] 23 repo_name = api.properties['repo_name']
24 codereview_auth = api.properties.get('codereview_auth', False) 24 codereview_auth = api.properties.get('codereview_auth', False)
25 force_checkout = api.properties.get('force_checkout', False) 25 force_checkout = api.properties.get('force_checkout', False)
26 patch_storage = api.properties.get('patch_storage', 'rietveld') 26 patch_storage = api.properties.get('patch_storage', 'rietveld')
27 27
28 api.gclient.set_config(repo_name) 28 api.gclient.set_config(repo_name, GIT_MODE=True)
29 29
30 kwargs = {} 30 kwargs = {}
31 if patch_storage == 'gerrit': 31 if patch_storage == 'gerrit':
32 kwargs['gerrit_rebase_patch_ref'] = True 32 kwargs['gerrit_rebase_patch_ref'] = True
33 bot_update_step = api.bot_update.ensure_checkout( 33 bot_update_step = api.bot_update.ensure_checkout(
34 force=force_checkout, 34 force=force_checkout,
35 patch_oauth2=codereview_auth, 35 patch_oauth2=codereview_auth,
36 **kwargs) 36 **kwargs)
37 relative_root = api.gclient.calculate_patch_root( 37 relative_root = api.gclient.calculate_patch_root(
38 api.properties['patch_project']).rstrip('/') 38 api.properties['patch_project']).rstrip('/')
(...skipping 195 matching lines...) Expand 10 before | Expand all | Expand 10 after
234 234
235 yield ( 235 yield (
236 api.test('presubmit-infra-failure') + 236 api.test('presubmit-infra-failure') +
237 api.properties.tryserver( 237 api.properties.tryserver(
238 mastername='tryserver.chromium.linux', 238 mastername='tryserver.chromium.linux',
239 buildername='chromium_presubmit', 239 buildername='chromium_presubmit',
240 repo_name='chromium', 240 repo_name='chromium',
241 patch_project='chromium') + 241 patch_project='chromium') +
242 api.step_data('presubmit', api.json.output({}, retcode=2)) 242 api.step_data('presubmit', api.json.output({}, retcode=2))
243 ) 243 )
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698