scripts/slave/recipes/run_presubmit.py - Issue 2269263002: Make all the rest of the recipes explicitly specify GIT_MODE

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: scripts/slave/recipes/run_presubmit.py

Issue 2269263002: Make all the rest of the recipes explicitly specify GIT_MODE (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@master

Patch Set: Rebase Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « scripts/slave/recipes/perf/telemetry_harness_upload.expected/basic.json ('k') | scripts/slave/recipes/run_presubmit.expected/catapult.json » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: scripts/slave/recipes/run_presubmit.py

diff --git a/scripts/slave/recipes/run_presubmit.py b/scripts/slave/recipes/run_presubmit.py

index 861a7a4b10e42dea069fdc63f5980c678d53aedf..21a65f296ce5f2cba02a82f165918a893f3749d0 100644

--- a/scripts/slave/recipes/run_presubmit.py

+++ b/scripts/slave/recipes/run_presubmit.py

@@ -25,7 +25,7 @@ def _RunStepsInternal(api):

force_checkout = api.properties.get('force_checkout', False)

patch_storage = api.properties.get('patch_storage', 'rietveld')

- api.gclient.set_config(repo_name)

+ api.gclient.set_config(repo_name, GIT_MODE=True)

kwargs = {}

if patch_storage == 'gerrit':