scripts/slave/recipes/nacl/sdk_build.py - Issue 2269263002: Make all the rest of the recipes explicitly specify GIT_MODE

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: scripts/slave/recipes/nacl/sdk_build.py

Issue 2269263002: Make all the rest of the recipes explicitly specify GIT_MODE (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@master

Patch Set: Rebase Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « scripts/slave/recipes/nacl/sdk.expected/basic.json ('k') | scripts/slave/recipes/nacl/sdk_build.expected/basic.json » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: scripts/slave/recipes/nacl/sdk_build.py

diff --git a/scripts/slave/recipes/nacl/sdk_build.py b/scripts/slave/recipes/nacl/sdk_build.py

index afb9d34c359b1d7c580eec2459db455053bb52ab..8b5632c1869f283dc36242da68c29376d527c00b 100644

--- a/scripts/slave/recipes/nacl/sdk_build.py

+++ b/scripts/slave/recipes/nacl/sdk_build.py

@@ -17,7 +17,7 @@ DEPS = [

def RunSteps(api):

api.chromium.set_config('chromium', GIT_MODE=True)

api.chromium.apply_config('mb')

- api.gclient.set_config('chromium')

+ api.gclient.set_config('chromium', GIT_MODE=True)

api.bot_update.ensure_checkout(force=True)

api.tryserver.maybe_apply_issue()

api.chromium.runhooks()

« no previous file with comments | « scripts/slave/recipes/nacl/sdk.expected/basic.json ('k') | scripts/slave/recipes/nacl/sdk_build.expected/basic.json » ('j') | no next file with comments »