Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issue 2269183003: DevTools: Merge CodeMirrorTextEditor's copyRange into text (Closed)

Created:
4 years, 3 months ago by einbinder
Modified:
4 years, 3 months ago
Reviewers:
lushnikov
CC:
apavlov+blink_chromium.org, blink-reviews, caseq+blink_chromium.org, chromium-reviews, devtools-reviews_chromium.org, kozyatinskiy+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, pfeldman
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: Merge CodeMirrorTextEditor's copyRange into text This is in preperation for CodeMirror-based console BUG=607690 Committed: https://crrev.com/4beff26238184abd3d3b6cde0fcda863f2a9300a Cr-Commit-Position: refs/heads/master@{#414171}

Patch Set 1 #

Messages

Total messages: 12 (7 generated)
einbinder
Ptal. This patch simplifies the public interface on CMTE.
4 years, 3 months ago (2016-08-23 23:42:53 UTC) #2
lushnikov
lgtm
4 years, 3 months ago (2016-08-24 21:58:47 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2269183003/1
4 years, 3 months ago (2016-08-24 22:13:17 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-08-24 22:19:25 UTC) #10
commit-bot: I haz the power
4 years, 3 months ago (2016-08-24 22:23:53 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4beff26238184abd3d3b6cde0fcda863f2a9300a
Cr-Commit-Position: refs/heads/master@{#414171}

Powered by Google App Engine
This is Rietveld 408576698