Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(71)

Unified Diff: third_party/WebKit/Source/devtools/front_end/source_frame/TextEditorAutocompleteController.js

Issue 2269183003: DevTools: Merge CodeMirrorTextEditor's copyRange into text (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/source_frame/TextEditorAutocompleteController.js
diff --git a/third_party/WebKit/Source/devtools/front_end/source_frame/TextEditorAutocompleteController.js b/third_party/WebKit/Source/devtools/front_end/source_frame/TextEditorAutocompleteController.js
index 97435da72926a644be34384c8ade8a59e46f2b1a..7e9001a9608c88d48900dbd22b1771161c9691bf 100644
--- a/third_party/WebKit/Source/devtools/front_end/source_frame/TextEditorAutocompleteController.js
+++ b/third_party/WebKit/Source/devtools/front_end/source_frame/TextEditorAutocompleteController.js
@@ -125,8 +125,8 @@ WebInspector.TextEditorAutocompleteController.prototype = {
if (!this._dictionary || prefixRange.startColumn === prefixRange.endColumn)
return Promise.resolve([]);
- var completions = this._dictionary.wordsWithPrefix(this._textEditor.copyRange(prefixRange));
- var substituteWord = this._textEditor.copyRange(substituteRange);
+ var completions = this._dictionary.wordsWithPrefix(this._textEditor.text(prefixRange));
+ var substituteWord = this._textEditor.text(substituteRange);
if (this._dictionary.wordCount(substituteWord) === 1)
completions = completions.filter((word) => word !== substituteWord);
@@ -209,12 +209,12 @@ WebInspector.TextEditorAutocompleteController.prototype = {
var selections = this._codeMirror.listSelections();
if (selections.length <= 1)
return true;
- var mainSelectionContext = this._textEditor.copyRange(mainSelection);
+ var mainSelectionContext = this._textEditor.text(mainSelection);
for (var i = 0; i < selections.length; ++i) {
var wordRange = this._substituteRange(selections[i].head.line, selections[i].head.ch);
if (!wordRange)
return false;
- var context = this._textEditor.copyRange(wordRange);
+ var context = this._textEditor.text(wordRange);
if (context !== mainSelectionContext)
return false;
}
@@ -238,7 +238,7 @@ WebInspector.TextEditorAutocompleteController.prototype = {
var prefixRange = substituteRange.clone();
prefixRange.endColumn = cursor.ch;
- var prefix = this._textEditor.copyRange(prefixRange);
+ var prefix = this._textEditor.text(prefixRange);
var hadSuggestBox = false;
if (this._suggestBox)
hadSuggestBox = true;
@@ -277,7 +277,7 @@ WebInspector.TextEditorAutocompleteController.prototype = {
this._clearHintMarker();
if (!this._isCursorAtEndOfLine())
return;
- var prefix = this._textEditor.copyRange(this._prefixRange);
+ var prefix = this._textEditor.text(this._prefixRange);
this._lastPrefix = prefix;
this._hintElement.textContent = hint.substring(prefix.length).split("\n")[0];
var cursor = this._codeMirror.getCursor("to");

Powered by Google App Engine
This is Rietveld 408576698