third_party/WebKit/Source/devtools/front_end/source_frame/SourceFrame.js - Issue 2269183003: DevTools: Merge CodeMirrorTextEditor's copyRange into text

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/source_frame/SourceFrame.js

Issue 2269183003: DevTools: Merge CodeMirrorTextEditor's copyRange into text (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/source_frame/CodeMirrorTextEditor.js ('k') | third_party/WebKit/Source/devtools/front_end/source_frame/TextEditorAutocompleteController.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/source_frame/SourceFrame.js

diff --git a/third_party/WebKit/Source/devtools/front_end/source_frame/SourceFrame.js b/third_party/WebKit/Source/devtools/front_end/source_frame/SourceFrame.js

index fdda3c26e1fa99b3225f1d5f6f923b652dbf2a40..fe07c5d67b5b7f40de45a8ce48541b2a6b2ea6d3 100644

--- a/third_party/WebKit/Source/devtools/front_end/source_frame/SourceFrame.js

+++ b/third_party/WebKit/Source/devtools/front_end/source_frame/SourceFrame.js

@@ -488,7 +488,7 @@ WebInspector.SourceFrame.prototype = {

return;

this._textEditor.highlightSearchResults(this._searchRegex, null);

- var oldText = this._textEditor.copyRange(range);

+ var oldText = this._textEditor.text(range);

var regex = searchConfig.toSearchRegex();

var text;

if (regex.__fromRegExpQuery)

@@ -623,7 +623,7 @@ WebInspector.SourceFrame.prototype = {

}

textRange = textRange.normalize();

- var selectedText = this._textEditor.copyRange(textRange);

+ var selectedText = this._textEditor.text(textRange);

if (textRange.startLine === textRange.endLine)

this._sourcePosition.setText(WebInspector.UIString("%d characters selected", selectedText.length));

else